Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove write and add more details on read. #456

Merged
merged 7 commits into from
Nov 1, 2023

Conversation

snianu
Copy link
Contributor

@snianu snianu commented Oct 27, 2023

Closes #????

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Implementation commitment:

@snianu snianu requested a review from sanketj October 27, 2023 18:32
sanketj

This comment was marked as resolved.

@snianu
Copy link
Contributor Author

snianu commented Oct 28, 2023

@sanketj Addressed all comments. PTAL.
For write I can create a new explainer to describe the changes we're making in the sanitization and mention it in the read explainer as a link. wdyt?

docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
@sanketj
Copy link
Member

sanketj commented Oct 30, 2023

@sanketj Addressed all comments. PTAL. For write I can create a new explainer to describe the changes we're making in the sanitization and mention it in the read explainer as a link. wdyt?

Thinking about this some more, I don't think we can specify that write should provide unsanitized HTML as Safari has different behavior. Perhaps it is sufficient to mention in this explainer that the unsanitized option in read also allows browsers that write unsanitized HTML to roundtrip HTML content better?

@snianu
Copy link
Contributor Author

snianu commented Oct 30, 2023

@sanketj Addressed all comments. PTAL. For write I can create a new explainer to describe the changes we're making in the sanitization and mention it in the read explainer as a link. wdyt?

Thinking about this some more, I don't think we can specify that write should provide unsanitized HTML as Safari has different behavior. Perhaps it is sufficient to mention in this explainer that the unsanitized option in read also allows browsers that write unsanitized HTML to roundtrip HTML content better?

Added this in the intro section. Thanks!

docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
@snianu
Copy link
Contributor Author

snianu commented Oct 31, 2023

@sanketj Addressed all comments. PTAL, thanks!

docs/clipboard-unsanitized/explainer.md Show resolved Hide resolved
docs/clipboard-unsanitized/explainer.md Outdated Show resolved Hide resolved
@snianu snianu merged commit 39448ce into w3c:gh-pages Nov 1, 2023
1 check passed
@snianu snianu deleted the update-unsanitized-html-4 branch November 1, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants