Issue #2 - Updated diagram with latest methods

[steelejoe]

Updating stack-overview diagram to reflect latest methods

[ddorwin]

Thanks. LG except for some visual issues and nits. Please also change the commit message to be "Fix #2: Update the figure" or something like that. The important part is "Fix #2:"

Unless otherwise noted, these issues appear in both Chrome and Firefox.

• In Firefox, text is no longer centered. Examples: CDN, Net, MediaKeySession, CDM. Also, Media Stack runs into the first MediaKeySession.
• The first MediaKeySession is not centered even in Chrome. In Firefox, it extends outside its box.
• The font changed. The main problem is that the italics text looks bad, especially the e's.
• The MediaKeySession boxes appear to be at an angle. When scaled up, the horizontal lines are not straight.
• The optional (right) update arrow still has a weird double head.
• Please make the heads of the left update() arrow and the top (up) Frame arrow touch their target objects.

[ddorwin]

• The MediaKeySession boxes are different sizes. I think the right one can be trimmed on the right.

[steelejoe]

I think this has everything you wanted. You are correct the fonts changed, because the original SVG (as far as I can tell) used outlining which looks nice but does not preserve font information. So I made a best guess. I believe the wonky arrows heads should all be corrected as well.

[ddorwin]

LGTM. Thanks!

Is there a reason the title was changed back? Perhaps when you force pushed the new commit, replacing the previous one?

There are a couple minor issues, but we can fix those in a separate PR if you want:

• The MediaKeySession boxes appear to be at an angle. When scaled up, the horizontal lines are not straight. This is more pronounced in Chrome that in Firefox.
• The Frame up arrow appears to have a double head.

[steelejoe]

The title change was likely the force commit. I am not seeing the slant you are seeing on Chrome or Firefox, but I will test on other platforms. Let me put together another PR.

[ddorwin]

I can't perceive a slant, but the horizontal lines are not solid as if they are at an angle. Like ~~~----___ but more subtle. This is more obvious at high resolutions.

[ddorwin]

@steelejoe, what do you want to do? Shall we commit this and continue to fix minor details later?

[ddorwin]

@steelejoe, should we land this and make improvements later?

[steelejoe]

Sorry was looking into the wrong place for updates. Yes please. Let's
commit this and I will work on correcting the slant after.
On Mar 24, 2016 10:41 AM, "ddorwin" notifications@github.com wrote:

@steelejoe https://github.com/steelejoe, should we land this and make
improvements later?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#143 (comment)

[ddorwin]

Merged as 336e7bd. Thank you!