Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generic technique identifiers #1868

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Remove generic technique identifiers #1868

merged 3 commits into from
Oct 29, 2021

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Oct 25, 2021

Also worth noting is that we have permalinks for each section, so having these labels that match the IDs isn't helpful anymore in terms of linking to sections.

Fixes #1866

Copy link
Contributor

@clapierre clapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Matt

@iherman
Copy link
Member

iherman commented Oct 26, 2021

Looks o.k. to me. Just out of curiosity: is the class "suppress-numbering" defined by respec? Because I do not see it in the respec doc...

@mattgarrish
Copy link
Member Author

is the class "suppress-numbering" defined by respec?

No, that was what we used in IDPF. I didn't spot those on the section tags, but will remove them, too.

@mattgarrish mattgarrish merged commit b4bc83a into main Oct 29, 2021
@mattgarrish mattgarrish deleted the editorial/issue-1866 branch October 29, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove technique numbering
3 participants