Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update certifierCredential and certifierReport #1435

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Update certifierCredential and certifierReport #1435

merged 1 commit into from
Dec 16, 2020

Conversation

mattgarrish
Copy link
Member

This pull request makes the following changes for the certifierCredential and certifierReport properties:

  • fixes the definitions to say "the associated certifiedBy property"
  • adds the "Extends" field to the definition table to additionally specify these are only associated with certifiedBy
  • updates all examples with the properties to link them to a certifier using the refines attribute

Fixes #1410

Accessibility preview
Accessibility diff

@mattgarrish
update the definitions and example of certifierCredential and certifi…
aa320bc 
…erReport to make clear they are associated with a certifier
clapierre
clapierre approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@clapierre clapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattgarrish mattgarrish merged commit 8457682 into master Dec 16, 2020
@mattgarrish mattgarrish deleted the fix/issue-1410 branch December 16, 2020 16:54
@murata2makoto
Copy link
Contributor

The two links (Accessibility preview and Accessibility diff) do not work.

@mattgarrish
Copy link
Member Author

The two links (Accessibility preview and Accessibility diff) do not work.

The links won't work once the branches are merged; that's one of the limitations of having multiple specifications. Only the core spec diffs and previews are retained for a while as the pr-preview program copies them to an aws server. I don't know how long they're retained, though.

@murata2makoto
Copy link
Contributor

@mattgarrish Thanks for your clarification. I guess that we have to live with this limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clapierre clapierre clapierre approved these changes

@GeorgeKerscher GeorgeKerscher Awaiting requested review from GeorgeKerscher

@avneeshsingh avneeshsingh Awaiting requested review from avneeshsingh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify credentials need to be associated with certifier
3 participants
@mattgarrish @murata2makoto @clapierre