-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to persistent storage security #2301
Conversation
…from unrelated documents; add authoring recommendations not to store sensitive user data in persistent storage or to encrypt it if it must be stored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the deleted MUST from tinyurl.com/epub-tests in anticipation of this being committed.
The issue was discussed in a meeting on 2022-05-26 List of resolutions:
View the transcript1.5. Persistent storage security.See github pull request epub-specs#2301. See github issue epub-specs#2264. Dave Cramer: about unrelated documents. Matt Garrish: this is about two requirements that were still in the spec, but which are no longer applicable. Dave Cramer: a lot of people have done proofs of concept of drafting epubs that can read data from local storage created by a different epub. Matt Garrish: not sure if javascript encrypting is trivial to break or not, but at least we are saying to pay attention to this.
|
This pull request removes the recommendation about limiting access to persistent storage from "unrelated documents" since the unique origin requirement already prevents other epub publications from accessing this data. (Note that this deletes a test id. Not sure if the test would be useful to keep for the unique origin requirement?)
Although I think this is sufficient for reading systems, I've also added a new paragraph to the security section in the core specification to make epub creators aware that older reading systems are susceptible to exploits. It recommends not storing sensitive user data in persistent storage, but if there is no other option then the data should be encrypted to prevent trivial access to the information. Feedback welcome on whether this is sufficient, or if we should be saying something more or something else.
Fixes #2264
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on May 22, 2022, 10:14 AM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.