Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding i18n test references #2312

Closed
wants to merge 2 commits into from
Closed

Adding i18n test references #2312

wants to merge 2 commits into from

Conversation

iherman
Copy link
Member

@iherman iherman commented May 25, 2022

This is the pair of w3c/epub-tests#150 : references to i18n tests. To be merged only when the tests are merged.

@iherman iherman requested a review from dlazin May 25, 2022 09:44
epub33/rs/index.html Outdated Show resolved Hide resolved
@mattgarrish
Copy link
Member

Is there any reason why these test PRs haven't been merged?

@iherman
Copy link
Member Author

iherman commented Jun 7, 2022

Because w3c/epub-tests#150 is still open; those review often result in naming changes which may influence these changes, too.

The real question is: when will @dlazin review the test repo's PR...

@iherman
Copy link
Member Author

iherman commented Jun 17, 2022

Closing this PR without merging by virtue of #2330

@iherman iherman closed this Jun 17, 2022
@mattgarrish mattgarrish deleted the tests/i18n-references branch June 17, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants