Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reference to symbolic links to the threat models (issue 2322) #2337

Merged
merged 1 commit into from Jun 22, 2022

Conversation

iherman
Copy link
Member

@iherman iherman commented Jun 21, 2022

The PR adds a reference to symbolic links to the threat models of both the core and the RS specs, essentially along the lines of what had been proposed in #2322 (comment). Both threat models already had an item on "malicious content", and that seemed like the good place to add this.

Because the threat models' section implicitly says to RS systems that "you ought to deal with these", adding a separate warning along these lines on symbolic links (and friends), as also mentioned in #2322 (comment), seemed superfluous.

I did not find a proper place to add a note on not using the -y option in the zip command; we do not refer to that command in the spec in the first place. So I dropped this, too.

Fix #2322

See:


Preview | Diff

@iherman iherman changed the title Adding reference to symbolic links to the threat models (issue 2322 Adding reference to symbolic links to the threat models (issue 2322) Jun 21, 2022
@mattgarrish
Copy link
Member

I did not find a proper place to add a note on not using the -y option in the zip command

It's not universal to all zip tools, either, so not sure it would make sense to call it out specifically.

Should we say anything in the recommendations about perhaps being less trusting of resources that are not declared in the package document? Something along the lines of although these are allowed, reading systems may want to attempt to verify their format before unpacking/allowing access to them?

@iherman
Copy link
Member Author

iherman commented Jun 21, 2022

I did not find a proper place to add a note on not using the -y option in the zip command

It's not universal to all zip tools, either, so not sure it would make sense to call it out specifically.

+1

Should we say anything in the recommendations about perhaps being less trusting of resources that are not declared in the package document? Something along the lines of although these are allowed, reading systems may want to attempt to verify their format before unpacking/allowing access to them?

Isn't that a separate issue? If I want to be nasty, I can create a symbolic link, and I then I declare it in the package document. I guess epubcheck may catch this, but that is simply because they are that good :-)

@mattgarrish
Copy link
Member

mattgarrish commented Jun 21, 2022

It's true for all resources since you can fake out epubcheck by declaring it as a foreign resource. Won't catch sideloaded content, either. This issue just highlights the problem.

@wareid wareid merged commit 824402a into main Jun 22, 2022
@mattgarrish mattgarrish deleted the symb-link-warning-issue-2322 branch July 5, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding malicious symbolic links to an EPUB publication
3 participants