Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-masking-1] [filters] Remove "* implements SVGUnitTypes" #90

Closed
foolip opened this issue Nov 16, 2016 · 5 comments
Closed

[css-masking-1] [filters] Remove "* implements SVGUnitTypes" #90

foolip opened this issue Nov 16, 2016 · 5 comments
Assignees
@nikosandronikos
Labels
css-masking-1 filter-effects-1 Needs Edits

Comments

@foolip
Copy link
Member

foolip commented Nov 16, 2016

See w3c/svgwg#291 (comment). (Editing this repo looks less trivial than most specs, so no PR.)
@foolip foolip changed the title [css-masking-1] [filters] Remove "* implements SVGUnitTypes [css-masking-1] [filters] Remove "* implements SVGUnitTypes" Nov 16, 2016
@foolip
Copy link
Member Author

foolip commented Nov 16, 2016

The interfaces are SVGClipPathElement, SVGMaskElement and SVGFilterElement.

foolip added a commit to web-platform-tests/wpt that referenced this issue Nov 16, 2016
@foolip
Test SVGUnitTypes changes (no longer a mixin)
1adc16c 
Tests for w3c/svgwg#291 and
w3c/fxtf-drafts#90
@foolip foolip mentioned this issue Nov 16, 2016
Merged
@foolip
Copy link
Member Author

foolip commented Nov 25, 2016

@nikosandronikos, do you know who to poke about these specs?

@nikosandronikos nikosandronikos mentioned this issue Nov 26, 2016
Merged
@tabatkins tabatkins removed the ready label Nov 29, 2016
@foolip
Copy link
Member Author

foolip commented Nov 29, 2016

There's also SVGClipPathElement and SVGMaskElement. Who has the power to reopen?

@dbaron dbaron reopened this Nov 30, 2016
nikosandronikos added a commit that referenced this issue Nov 30, 2016
@nikosandronikos
SVGClipPathElement and SVGMaskElement no longer implement SVGUnitTypes.
9bd0b9a 
Closes #90.
Related to w3c/svgwg/#291 and w3c/svgwg/#295.
@nikosandronikos nikosandronikos mentioned this issue Nov 30, 2016
Closed
@dirkschulze
Copy link
Contributor

I'll do the edits.

@dirkschulze
Copy link
Contributor

Done. Please review and reopen if I missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikosandronikos nikosandronikos

Labels
css-masking-1 filter-effects-1 Needs Edits
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dbaron @foolip @tabatkins @fantasai @dirkschulze @nikosandronikos