Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geometry] Treat 0 and -0 as equal throughout #159

Merged
merged 1 commit into from
May 19, 2017
Merged

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented May 15, 2017

This is consistent with other APIs such as JS's Map, Set, and
Array.prototype.includes.

Fixes #152.

@zcorpan zcorpan requested a review from domenic May 15, 2017 09:03
zcorpan added a commit to web-platform-tests/wpt that referenced this pull request May 15, 2017
@zcorpan
Copy link
Member Author

zcorpan commented May 15, 2017

Tests for DOMMatrixInit: web-platform-tests/wpt#5896

Copy link
Collaborator

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good, but I haven't done an audit that this comprehensively covers every place a zero could show up in the spec; I'll trust you on that front.

This is consistent with other APIs such as JS's Map, Set, and
Array.prototype.includes.

Fixes #152.
@zcorpan
Copy link
Member Author

zcorpan commented May 17, 2017

Thank you!

Could you also please review web-platform-tests/wpt#5896 ?

zcorpan added a commit to web-platform-tests/wpt that referenced this pull request May 19, 2017
@zcorpan zcorpan merged commit 8a00241 into master May 19, 2017
@zcorpan zcorpan deleted the zcorpan/samevaluezero branch May 19, 2017 08:41
@tabatkins tabatkins removed the ready label May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants