Correct inclusion of SVGURIReference #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an `interface mixin`, not an `interface`, so the operator is `includes` not `implements`. Found this when cleaning up the SVG deps for web-platform-tests/wpt#11796
|
Those were not updated yet because SVg2 wasn’t updated at the time. I need to check if that is the case now. |
|
I can confirm that for you; as linked in the description, web-platform-tests/wpt#11796 updated the SVG scrape I'm manually having to work around it in order to land scrape updates. |
|
@dirkschulze this looks good to me, any reason not to merge? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVGURIReference is an
interface mixin, not aninterface, so the operator isincludesnotimplements.Found this when cleaning up the SVG deps for web-platform-tests/wpt#11796