Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update address mappings #171

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Update address mappings #171

merged 2 commits into from
Feb 26, 2019

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Feb 26, 2019

Closes #170 and closes #166

These changes essentially remove any special mappings that were specified for the address element, instead exposing it more like a div.

@joanmarie and @stevefaulkner, please verify these changes.


Preview | Diff

closes #170
Removal of
* `AXRoleDescription: address`
* `Object attributes: address `
* `Localized Control Type: address`
* `Object attributes: xml-roles:address`
closes #166

Per the previous commit, further revisions to `address` to have it match `div`, so as to not convey more information than is necessary.
Copy link
Contributor

@joanmarie joanmarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@scottaohara scottaohara merged commit c01f76f into gh-pages Feb 26, 2019
@scottaohara scottaohara deleted the update_address branch February 26, 2019 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update mappings for address element Verify the IA2 mappings for the address element
2 participants