Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ATK mappings for ins and del #219

Merged
merged 1 commit into from
Jul 10, 2019
Merged

Update ATK mappings for ins and del #219

merged 1 commit into from
Jul 10, 2019

Conversation

joanmarie
Copy link
Contributor

@joanmarie joanmarie commented Jul 9, 2019

  • Update the platform role mappings to ATK_ROLE_CONTENT_INSERTION and
    ATK_ROLE_CONTENT_DELETION respectively. These new roles have landed
    in both ATK and AT-SPI2.
  • Add 'xml-roles' AtkObject attribute on each because if user agents use
    the old role (ATK_ROLE_SECTION), ATs will need a fallback to find out
    what the elements' role should be.

Closes #218

The following tasks have been completed:

  • Confirmed there are no ReSpec/BikeShed errors or warnings.
  • Modified Web platform tests (link to pull request)

Implementation commitment:


Preview | Diff

* Update the platform role mappings to ATK_ROLE_CONTENT_INSERTION and
  ATK_ROLE_CONTENT_DELETION respectively. These new roles have landed
  in both ATK and AT-SPI2.
* Add 'xml-roles' AtkObject attribute on each because if user agents use
  the old role (ATK_ROLE_SECTION), ATs will need a fallback to find out
  what the elements' role should be.
@joanmarie
Copy link
Contributor Author

Regarding implementation commitment, I'll try to do the implementations soon. :) I'll have to do them for the new ARIA roles anyway, so might as well do it at the same time....

@marcoscaceres
Copy link
Member

@joanmarie, thanks great to hear. I should update the template to include Orca, instead of just the browser engines? Be great to track progress/implantation commitments from you.

@joanmarie, also, our IPR bot is complaining that you are not a member of the WebApps WG. It would be great if you could join as an implementer. Anything I or @LJWatson can do to help with that?

@joanmarie
Copy link
Contributor Author

@marcoscaceres I used to be a member of WebPlatform. I guess I need to add myself to WebApps. Regarding Orca and "implementation":

  1. As I trust you know, Orca is a screen reader; not a user agent. I think we/you want implementations in user agents.
  2. When I say "implementations" I meant I would implement them in WebKitGtk, Chromium/Blink, and possibly Gecko; not in Orca. (I'll add support in Orca too, of course, but see item 1.)

@joanmarie
Copy link
Contributor Author

@marcoscaceres I should now be a WebApps member.

@marcoscaceres
Copy link
Member

I’m still learning so I honestly don’t know how this gets implemented 👶 I’m keen to learn tho, as I can at least help with reviews or even implement on the Gecko side.

So it sounds like the current template is for implementation commitment is fine. We should add file the appropriate bugs on each browser vendor so this doesn’t get lost.

If we can also get some Web Platform Tests, that would be amazing.

@marcoscaceres
Copy link
Member

All green regarding IPR commitment! Thanks for joining the WG. Looking forward to collaborating and learning from you.

@scottaohara scottaohara merged commit f6dd1b9 into w3c:gh-pages Jul 10, 2019
@joanmarie
Copy link
Contributor Author

WebKit is done: https://trac.webkit.org/changeset/247349. Note that I did it as part of a bigger, ARIA patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ATK mappings for ins and del need to be updated
3 participants