Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATK mappings for ins and del need to be updated #218

Closed
joanmarie opened this issue Jul 9, 2019 · 2 comments · Fixed by #219
Closed

ATK mappings for ins and del need to be updated #218

joanmarie opened this issue Jul 9, 2019 · 2 comments · Fixed by #219
Assignees

Comments

@joanmarie
Copy link
Contributor

#141 added mappings for ATK, however there are a couple of issues:

  1. There is no attribute included to identify that the ATK_ROLE_SECTION is an insertion or deletion. In order to be consistent with what has been done for other elements which have corresponding ARIA roles, I propose adding xml-roles:insertion for ins and xml-roles:deletion for del. This will be going into the Core-AAM.
  2. As agreed upon earlier, we should wait for the platform new roles to land in ATK and AT-SPI2. That has happened. See https://gitlab.gnome.org/GNOME/atk/commit/e3856ee2. The Core-AAM will also contain the new roles (ATK_ROLE_CONTENT_INSERTION and ATK_ROLE_CONTENT_DELETION)

I'm happy to do a pull request, but I don't know how you feel about when it's best to do 2.

@joanmarie joanmarie self-assigned this Jul 9, 2019
@joanmarie
Copy link
Contributor Author

Went ahead and did the pull request just in case. If you disagree, we can close it.

@scottaohara
Copy link
Member

Hey @joanmarie. 2 prs are fine with me. The second can be noted as not ready for merge until the time is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants