Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style changes on table: Rules of ARIA attributes usage by HTML language feature #141

Closed
pgrucza opened this issue May 22, 2019 · 7 comments · Fixed by #143
Closed

Style changes on table: Rules of ARIA attributes usage by HTML language feature #141

pgrucza opened this issue May 22, 2019 · 7 comments · Fixed by #143

Comments

@pgrucza
Copy link
Contributor

pgrucza commented May 22, 2019

With recent updates to the Editor's Draft there seems to be some styling changes to the table for Rules of ARIA attributes usage by HTML language feature.
The currently published Working Draft has grey table headings and is striped white and grey. Columns are also separated.
The Editor's Draft uses dark blue headings and is striped blue and grey. Columns are not visually separated. A class="simple" has been applied to the table.

I'm wondering if this styling change is intentional or is it a side effect of the recent updates?

@marcoscaceres
Copy link
Member

My bad. The change was... um... half intentional. We should probably remove any custom style from the spec and let basic.css handle the table styling.

@marcoscaceres
Copy link
Member

@pgrucza you want to take this one too? At least, have a play with removing the custom style in the spec and seeing if simple is enough.

@pgrucza
Copy link
Contributor Author

pgrucza commented May 27, 2019

I'll have a look ( likely tomorrow ). Is there anything I need to be aware of in your previous changes for the layout ?

@marcoscaceres
Copy link
Member

No, nothing that I can think of.

@pgrucza
Copy link
Contributor Author

pgrucza commented May 28, 2019

#133 added class="simple"
removing the class="simple" allows basic.css to do its work again

@marcoscaceres
Copy link
Member

removing the class="simple" allows basic.css to do its work again

Sorry, I think I might have confused you... ".simple" is part of basic.css. However, the document is adding "makeup.css", which includes some style rules for table. Those are the ones that need that need to be removed, I think... namely:

tr:nth-child(2n+1) {
  background-color: #ebebeb;
}

Which is conflicting with "simple".

@pgrucza
Copy link
Contributor Author

pgrucza commented May 29, 2019

ok returned class="simple" to the tables
removed:

tr:nth-child(2n+1) {
  background-color: #ebebeb;
} 

from makeup.css

This leaves the blue header row and light blue striping coming from simple. Inline ReSpec 3 CSS

For request, "fixing links in ahref and anohref" #143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants