Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tidy up document #133

Merged
merged 16 commits into from
May 21, 2019
Merged

chore: tidy up document #133

merged 16 commits into from
May 21, 2019

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 16, 2019

Closes #132


Preview | Diff

Copy link
Collaborator

@stevefaulkner stevefaulkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears to be lots of white space in update??

@marcoscaceres
Copy link
Member Author

We can flatten it if you would like? see the tidyconfig.txt

@marcoscaceres
Copy link
Member Author

Let me know what you are most comfortable with... I prefer the indenting, as I find table nesting quite challenging to edit manually. We can also boost the line length or whatever you like.

@stevefaulkner
Copy link
Collaborator

@marcoscaceres I am fine with it being flattened

@marcoscaceres
Copy link
Member Author

ok, flat for ya :) what about line length? Keep 80?

@marcoscaceres
Copy link
Member Author

marcoscaceres commented May 16, 2019

Also... about the indenting.... I'm worried that without it, external contributors might have a hard time making changes (specially people like me who are dyslexic). I'd really struggle with flat code, so it might be a service to the community to indent the code.

@stevefaulkner
Copy link
Collaborator

@marcoscaceres I am also fine with indenting :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec needs tidy and cleanup
2 participants