fixing links in ahref and anohref #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,7 +152,7 @@ <h2 id="docconformance"> | |||
| </tr> | |||
| <tr id="ahref" tabindex="-1"> | |||
| <td> | |||
| <a><code>a</code></a> element with a <code>href</code></td> | |||
| <a><code>a</code></a> element with a <a data-cite="html/links.html#attr-hyperlink-href"><code>href</code></a></td> | |||
There was a problem hiding this comment.
Suggested change
| <a><code>a</code></a> element with a <a data-cite="html/links.html#attr-hyperlink-href"><code>href</code></a></td> | |
| <a>`a`</a> element with a <a data-cite="html/links.html#attr-hyperlink-href">`href`</a></td> |
There was a problem hiding this comment.
@marcoscaceres you seem to be suggesting the removal of the code elements and replacing them with markdown. The code element is being used in the rest of the document.
If this is part of a larger change to the markup, I'm not sure if this is the best place to start it.
There was a problem hiding this comment.
Yeah, we can do those in a new pull request.
| @@ -187,7 +187,7 @@ <h2 id="docconformance"> | |||
| </tr> | |||
| <tr id="anohref" tabindex="-1"> | |||
| <td> | |||
| <code>a</code></a> element without a <code>href</code> | |||
| <a><code>a</code></a> element without a <a data-cite="html/links.html#attr-hyperlink-href"><code>href</code></a> | |||
There was a problem hiding this comment.
Suggested change
| <a><code>a</code></a> element without a <a data-cite="html/links.html#attr-hyperlink-href"><code>href</code></a> | |
| <a>`a`</a> element without a <a data-cite="html/links.html#attr-hyperlink-href">`href`</a> |
marcoscaceres
approved these changes
May 27, 2019
|
Marked as non substantive for IPR from ash-nazg. |
marcoscaceres
requested changes
May 29, 2019
|
@pgrucza, you meed to accept my suggestions before I can merge this. |
|
Actually, will make the code changes independently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #141 and closes #142
applied changes as suggested in #142
Preview | Diff