Remove assumption that the table of contents will be an <ol>. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for c in li.iterchildren(): | ||
| if c.tag == 'a': | ||
| if c.get('href')[0] == '#': | ||
| items.append( (depth, c.get('href')[1:], c) ) | ||
| elif c.tag == 'ol': | ||
| elif c.attrib['class'] == 'toc': |
There was a problem hiding this comment.
This instead assumes that nested lists will have the 'toc' class, which is configurable in anolis. Check for "ol" or "ul" instead?
A recent change to anolis[1] caused it to output the table of contents using <ul> tags instead of <ol> tags, breaking the generation of the table of contents for individual pages. Instead, we search for <ul> or <ol> tags. [1] https://bitbucket.org/ms2ger/anolis/commits/62d9a108439d70e33ad2bb3b4009efd3dbf9cac5
darobin
added a commit
that referenced
this pull request
Sep 23, 2013
Remove assumption that the table of contents will be an <ol>.
|
This LGTM, thanks! @zcorpan Note that the important thing here is that it matches the Anolis settings used by the HTML spec; so long as we don't change that it works. (And given the styling we have, it seems unlikely that we'd change anything). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to anolis[1] caused it to output the table of contents
using
<ul>tags instead of<ol>tags, breaking the generation of thetable of contents for individual pages.
Instead, we now search for the table of contents by the toc class
without assuming what tag it will use.
[1] https://bitbucket.org/ms2ger/anolis/commits/62d9a108439d70e33ad2bb3b4009efd3dbf9cac5