Skip to content
This repository was archived by the owner on Jul 30, 2019. It is now read-only.

Allow internationalised email addresses #1163

Merged
merged 2 commits into from
Jan 30, 2018
Merged

Allow internationalised email addresses #1163

merged 2 commits into from
Jan 30, 2018

Conversation

chaals
Copy link
Collaborator

@chaals chaals commented Jan 29, 2018

Fix #845

@chaals chaals requested review from cynthia and r12a January 29, 2018 18:09
@chaals chaals requested review from edent and removed request for cynthia January 30, 2018 09:18
@edent
Copy link
Member

edent commented Jan 30, 2018 •
edited
Loading

For completeness, is it worth adding 你好@example.com?

Also, 屋企.香港 appears to be a real domain. Is there an example domain by the .中国 registry?

Based on https://www.hkirc.hk/content.jsp?&id=3&#!/6 there are some "reserved" domains which won't be assigned. 個人.香港

@LJWatson LJWatson merged commit 76e3747 into master Jan 30, 2018
plehegar pushed a commit that referenced this pull request Jan 30, 2018
Built by Travis-CI: 76e3747 Allow internationalised email addresses (#…
92496f2 
…1163)
@chaals chaals deleted the chaals-allow-unicode-email-address-845 branch January 30, 2018 21:37
@r12a r12a mentioned this pull request Feb 2, 2018
Closed
@r12a r12a mentioned this pull request Nov 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@r12a r12a Awaiting requested review from r12a

@edent edent Awaiting requested review from edent

Assignees
No one assigned
Labels
i18n-comment substantive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaals @edent @LJWatson