/html

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow internationalised email addresses #1163

Merged
merged 2 commits into from Jan 30, 2018

Conversation

Reviewers

@r12a r12a

@edent edent

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
3 participants
@chaals @edent @LJWatson
@chaals
Collaborator

chaals commented Jan 29, 2018

Fix #845

chaals added some commits Jan 29, 2018

chaals
Allow internationalised email addresses 
Fix #845
Loading status checks…
873ec12
chaals
add link
Loading status checks…
4280fe4

@chaals chaals requested review from cynthia and r12a Jan 29, 2018

@chaals chaals added i18n-comment substantive labels Jan 29, 2018

@chaals chaals requested review from edent and removed request for cynthia Jan 30, 2018

@edent

This comment has been minimized.

Show comment
Hide comment
@edent

edent Jan 30, 2018

Contributor

For completeness, is it worth adding 你好@example.com?

Also, 屋企.香港 appears to be a real domain. Is there an example domain by the .中国 registry?

Based on https://www.hkirc.hk/content.jsp?&id=3&#!/6 there are some "reserved" domains which won't be assigned. 個人.香港
Contributor

edent commented Jan 30, 2018 •
edited

For completeness, is it worth adding 你好@example.com?

Also, 屋企.香港 appears to be a real domain. Is there an example domain by the .中国 registry?

Based on https://www.hkirc.hk/content.jsp?&id=3&#!/6 there are some "reserved" domains which won't be assigned. 個人.香港

@LJWatson LJWatson merged commit 76e3747 into master Jan 30, 2018
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ipr PR deemed acceptable.
Details

plehegar pushed a commit that referenced this pull request Jan 30, 2018

Travis CI
Built by Travis-CI: 76e3747 Allow internationalised email addresses (#… 
…1163)
92496f2

@chaals chaals deleted the chaals-allow-unicode-email-address-845 branch Jan 30, 2018

@r12a r12a referenced this pull request Feb 2, 2018

Open

allow input type="email" to accept unicode values #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment