Skip to content
This repository has been archived by the owner. It is now read-only.

Allow internationalised email addresses #1163

Merged
merged 2 commits into from Jan 30, 2018

Conversation

@chaals
Copy link
Collaborator

@chaals chaals commented Jan 29, 2018

Fix #845

chaals added 2 commits Jan 29, 2018
chaals
Fix #845
chaals
@chaals chaals requested review from cynthia and r12a Jan 29, 2018
@chaals chaals requested review from edent and removed request for cynthia Jan 30, 2018
@edent
Copy link
Member

@edent edent commented Jan 30, 2018

For completeness, is it worth adding 你好@example.com?

Also, 屋企.香港 appears to be a real domain. Is there an example domain by the .中国 registry?

Based on https://www.hkirc.hk/content.jsp?&id=3&#!/6 there are some "reserved" domains which won't be assigned. 個人.香港

@LJWatson LJWatson merged commit 76e3747 into master Jan 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ipr PR deemed acceptable.
Details
plehegar pushed a commit that referenced this pull request Jan 30, 2018
@chaals chaals deleted the chaals-allow-unicode-email-address-845 branch Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants