This repository has been archived by the owner on Jul 30, 2019. It is now read-only.
Shwetank 194 clarify input date onchange #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaals
suggested changes
Apr 2, 2018
sections/semantics-forms.include
Outdated
| @@ -3761,6 +3761,8 @@ | |||
| When the element is <a>suffering from a step mismatch</a>, the user agent may round the | |||
| element's <a for="forms">value</a> to the nearest <a for="dates">date</a> for which the element would not <a>suffer from a step mismatch</a>. | |||
|
|
|||
| The <code>change</code> event is fired whenever the user has selected a new <a>valid date string</a> - which can be triggered when the user enters a new value. When a user changes a new <a>valid date string</a> or uses a stepping function to increment or decrement a part of the overall date string, user agents may apply a timeout to determine that the changed value is no longer intermediate. At the completion of such timeout, <code>change</code> must fire. Moving focus away from the date picker component or explicitly confirming with a button are unambigous triggers that the user wants the value changed, and <code>change</code> should fire on all such cases if the new date value is different than the previous one. | |||
|
|
|||
There was a problem hiding this comment.
Nitpicking: Can you please break up the line to around 100 characters? At the end of HTML elements is often a good spot.
I would move the "when the user changes, or is stepping though" clause to the end.
In that piece I don't think it should say that user agents must fire anything, just make it clear that it is possible they do so.
chaals
approved these changes
Apr 3, 2018
|
You could tweak this a bit further, e.g. breaking lines into smaller chunks (the primary use case for that is for reading github diffs without horizontal scrolling). But equally, feel free to merge as is if you don't have time for that now. It's not the highest priority issue :) |
chaals
reviewed
Apr 3, 2018
| @@ -3761,6 +3761,13 @@ | |||
| When the element is <a>suffering from a step mismatch</a>, the user agent may round the | |||
| element's <a for="forms">value</a> to the nearest <a for="dates">date</a> for which the element would not <a>suffer from a step mismatch</a>. | |||
|
|
|||
| The <code>change</code> event is fired whenever the user selects a new <a>valid date string</a>. | |||
| Moving focus away from the date picker component or explicitly confirming with a button are unambigous triggers that the user wants the value changed. | |||
| The event should be fired on all such cases if the new date value is different than the previous one. | |||
There was a problem hiding this comment.
s/should/must/
This is a real conformance requirement...
plehegar
pushed a commit
that referenced
this pull request
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 194
Clarifies how and when
changeevent should fire to date input types.