Adds capture attribute #1366
Adds capture attribute #1366
Conversation
LJWatson
commented
Apr 12, 2018
LJWatson
commented
- First draft (needs careful review)
- Adds capture to list of allowed attributes
- Adds capture to the table of allowed attributes per type state
- Adds capture to the bookkeeping information for each type state
- Adds section to locally reference capture (pointing to HTML Media Capture as the normative deifnition
- Will fix HTML media capture #1296 .
* First draft (needs careful review) * Adds capture to list of allowed attributes * Adds capture to the table of allowed attributes per type state * Adds capture to the bookkeeping information for each type state * Adds section to locally reference capture (pointing to HTML Media Capture as the normative deifnition.
There was a problem hiding this comment.
The Device and Sensors WG should be listed in acknowledgements.
This should be listed in changes.
I have not yet reviewed carefully for technical accuracy - it looks OK, but diff format is almost unreadable for this. So that check will take a little more time ;(
sections/semantics-forms.include
Outdated
| @@ -6902,6 +6925,10 @@ You cannot submit this form when the field is incorrect.</samp></pre> | |||
| </tr> | |||
| </table> | |||
|
|
|||
| <h6 id="the-capture-attribute">The <code>capture</code> attribute</h6> | |||
|
|
|||
| The <dfn element-attr for="input"><code>capture</code><dfn> attribute is defined in the [[!html-media-capture]] specification. The <code>capture</a> attribute specifies the preferred facing mode for the media capture mechanism. | |||
There was a problem hiding this comment.
mismatched element (opens as code, closed as a.
There was a problem hiding this comment.
Rather than defining the attribute in here we should probably refer to the source spec. I will make a PR against the branch to do that.
sections/semantics-forms.include
Outdated
| <{input/checked}>, | ||
| <{input/dirname}>, | ||
| <{input/dirname}>, |
There was a problem hiding this comment.
Odd whitespace insertion - probably not critical (although sometimes whitespace oddities break the bikeshed builder).
| @@ -1584,6 +1584,7 @@ | |||
| <dd><{input/autocapitalize}> - Hint for helping to capitalize user input</dd> | |||
| <dd><{input/autocomplete}> - Hint for form autofill feature</dd> | |||
| <dd><{input/autofocus}> - Automatically focus the form control when the page is loaded</dd> | |||
| <dd><{input/capture}> - Specifies the preferred facing mode for the media capture mechanism, defined in [[!html-media-capture]]</dd> | |||
There was a problem hiding this comment.
There should be a direct link for the attribute. As mentioned offline, I will make a PR against your branch to do that.
|
@chaals done. |
