-
Notifications
You must be signed in to change notification settings - Fork 533
Accesskey must be one character #168
Accesskey must be one character #168
Conversation
fix #20 Anything else (such as using multiple values, as suggested in HTML5) means that except in Internet Explorer, there is no `accesskey` assigned at all.
If specified, the value must be an <a>ordered set of unique space-separated tokens</a> | ||
that are <a>case-sensitive</a>, each of which must be exactly one Unicode code point in | ||
length. | ||
If specified, the value must be a single printable character: a string exactly one Unicode code point in length. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: can there be whitespace around the character? Do we need to handle trimming of whitespace when processing the attribute?
Test: https://chaals.github.io/accesskey/tests/accesskey-latin-with-spaces-manual.html Most browsers fail if they find the character surrounded by spaces :( It's a good idea as a browser to trim whitespace, but authors shouldn't put it there or their shortcuts will disappear. |
Hmm. I can make this clearer - hold on a bit. |
Adjust the algorithm to allow what IE really does, since that's better than other browsers.
This should do a better job of reflecting reality. (Oh, wait…) |
Some advice to improve likely compatibility with reality.
Yeah, now should be good enough for standards work. It's at least a substantial improvement on what used to be there, in matching reality - and no longer says IE's extra-good behaviour is wrong. |
OK. We can continue to refine in subsequent commits if necessary. |
fix #20
Anything else (such as using multiple values, as suggested in HTML5)
means that except in Internet Explorer, there is no
accesskey
assigned at all.
See tests at http://chaals.github.io/accesskey/tests/index.html