Skip to content
This repository has been archived by the owner on Jul 30, 2019. It is now read-only.

Strengthen advice to keep default context menu available #882

Merged
merged 3 commits into from May 22, 2017

Conversation

chaals
Copy link
Collaborator

@chaals chaals commented Apr 18, 2017

This changes the suggestion that user agents "may" make the default context menu available to a should, and rationalises the two paragraphs of example implementation suggestions into one.

In practice the only current implementation of menu for context menus already does this.

This changes the suggestion that user agents "may" make the default context menu available to a should, and rationalises the two paragraphs of example implementation suggestions into one.

In practice the only current implementation of `menu` for context menus already does this.
Copy link
Member

@travisleithead travisleithead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first sentence has some quirky and ambiguous grammar, but since it was bad before your change, I won't suggest changes unless you want to try to clean it up. Otherwise, LGTM!

Per review comment
@chaals chaals merged commit 7e95c01 into master May 22, 2017
@LJWatson LJWatson deleted the chaals-patch-context-menus-853 branch August 8, 2017 16:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants