Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate the Getting Started page into Chinese #358

Merged
merged 4 commits into from
May 6, 2022

Conversation

xfq
Copy link
Member

@xfq xfq commented Apr 27, 2022

I also fixed some typos in the English version.

@xfq xfq changed the title [WIP] Translate the Getting Started page into Chinese Translate the Getting Started page into Chinese Apr 28, 2022
@xfq xfq marked this pull request as ready for review April 28, 2022 08:09
@xfq xfq requested a review from r12a April 28, 2022 08:20
@r12a
Copy link
Contributor

r12a commented Apr 28, 2022

@xfq I see that this is marked for requesting review, but i also see that you didn't translate the descriptions just below the links. Is the review phase premature, or were you intending not to translate those sentences?

@xfq
Copy link
Member Author

xfq commented May 5, 2022

I wrote "titles in English mean that the article does not have a Simplified Chinese version" (in Chinese) at the top. Since a Chinese translator is translating a lot of the articles mentioned on this page, we will hopefully have more Chinese content on this page soon.

The reason I didn't translate the titles is that I want the titles here to be the same as the translated titles, and the reason I didn't translate the descriptions below the titles is that many of the descriptions come from the article, and I want the descriptions to be the same as the descriptions in the (translated) article.

@r12a
Copy link
Contributor

r12a commented May 5, 2022

Ok for the titles. I just thought that the descriptions are useful to translate to give a Chinese reader an idea of what the link is about. It's up to you. Let me know.

@xfq
Copy link
Member Author

xfq commented May 6, 2022

OK. I have translated the descriptions.

@r12a r12a merged commit 2d9085c into gh-pages May 6, 2022
@xfq xfq deleted the xfq/getting-started-zh-hans branch May 7, 2022 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants