Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate #387

Closed
wants to merge 2 commits into from
Closed

Boilerplate #387

wants to merge 2 commits into from

Conversation

brandelune
Copy link
Contributor

added untranslated strings.

Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing these changes. See, however, a couple of needed corrections in my comments.

javascript/boilerplate-text/boilerplate-fr.js Show resolved Hide resolved
s.askI18nActivity = "Ask for help or information."
s.ask = "Ask"
s.aboutI18nActivity = "Pour en savoir plus sur l'internationalisation au W3C."
s.about = "En savoir plus"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the standard translation for "About" in the sense of "About the W3C i18n Activity"? It's not really a question of learning more, but specifically about information related to the organisation. Perhaps something like á propos?? (Just asking)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that we try to keep these translations as short as possible. It's fine if there's no one word translation in French, but the shorter we can keep it the better.

@@ -113,6 +114,7 @@ s.validXHTML = "XHTML 1.0 valide !";
s.validCSS = "CSS valide !";
s.codedInUtf8 = "Codé en UTF-8 !";

s.translatedFromEnglishVer = "Traduit d’un contenu en anglais daté du "+dt.enVersion+". Dernière modification de cette traduction le "+dt.thisVersionPlain+" UTC.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this line is here. The translation already exists at line 126 of your version.

@brandelune
Copy link
Contributor Author

I'll update the file with the contents of the English translation. Sorry for the hassle.

@brandelune brandelune closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants