Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update per Netflix whitepaper #9

Merged
merged 4 commits into from Nov 20, 2017

Conversation

palemieux
Copy link
Contributor

Closes #8
Closes #3

Also refactored tts:textShadow per https://www.w3.org/AudioVideo/TT/tracker/issues/234

@palemieux palemieux self-assigned this Nov 6, 2017
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question asked about FCC requirements.

<section>
<h3><code>#textShadow</code></h3>

<p>To support the edge styles required by the FCC, [[!ttml-imsc1.1]] Text Profile SHALL support the <code>#textShadow</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this genuinely a requirement of FCC that is not currently met with textOutline? I thought that had already been deemed sufficient.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikedo What say you?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with tts:textOutline but I can not remember what they have been. Possibly we can look at some examples.

Copy link
Contributor Author

@palemieux palemieux Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues with tts:textOutline but I can not remember what they have been. Possibly we can look at some examples.

Per the joint CSS/TTWG meeting, text-outline is not well-supported in UAs today. No one disputed the value of the feature however -- as I recall.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I recall - the problem with tts:textOutline is not that it is a poor fit for the requirement, but that it is not widely implemented. If it were implemented, presumably support for #textShadow would no longer be required to support the edge styles required by FCC?

Copy link

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubyAlign should be 'auto' only if it means center, otherwise 'center' should also be allowed. The white paper was not so clear.

rubyPosition 'auto' would be fine if defined to map 'outside'

I think it misses writing-mode.

@palemieux
Copy link
Contributor Author

palemieux commented Nov 9, 2017

I think it misses writing-mode.

@cconcolato writingMode is already allowed in IMSC 1.1

@palemieux
Copy link
Contributor Author

palemieux commented Nov 9, 2017

rubyPosition 'auto' would be fine if defined to map 'outside'

@cconcolato Why not constrain rubyPosition="outside" then? Or do you mean that both auto and outside need to be allowed.

@palemieux
Copy link
Contributor Author

rubyAlign should be 'auto' only if it means center, otherwise 'center' should also be allowed. The white paper was not so clear.

@cconcolato Should we constrain rubyAlign="center" then? Or do you mean that both auto and center need to be allowed?

@cconcolato
Copy link

For rubyPosition and rubyAlign, we care for the default behavior, whatever the keyword value is.

Copy link

@cconcolato cconcolato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palemieux palemieux merged commit 261c243 into master Nov 20, 2017
@mikedo
Copy link

mikedo commented Nov 20, 2017

@nigelmegitt Is this genuinely a requirement of FCC that is not currently met with textOutline? I thought that had already been deemed sufficient.

textShadow better matches the FCC requirements than textOutline, but I need time to study whether textShadow alone is sufficient.

@palemieux palemieux deleted the issue-8-update-per-Netflix-whitepaper branch April 11, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants