Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test directory #153

Closed
palemieux opened this issue Feb 3, 2016 · 5 comments
Closed

Refactor test directory #153

palemieux opened this issue Feb 3, 2016 · 5 comments
Assignees
Milestone

Comments

@palemieux
Copy link
Contributor

test/
  w3c/
  contrib/
    dece/
    skynav/

putting the "formal" testsuite files into test/w3c

See #152 (comment)

@palemieux palemieux self-assigned this Feb 3, 2016
@palemieux palemieux added this to the imsc1-cr4 milestone Feb 3, 2016
palemieux added a commit that referenced this issue Feb 4, 2016
@palemieux
Copy link
Contributor Author

The testuite/src directory was moved to misc/dece since the code was used exclusively to make an initial transformation of the DECE content

@skynavga
Copy link
Contributor

skynavga commented Feb 5, 2016

I see you didn't quite adopt the indicated directory structure. It would be
better to add the internal w3c and contrib nodes, placing the w3c tests
under the former and the dece and skynav tests under the latter. Also, it
would be better to rename the top node to test rather than testsuite, since
not all of its content is the "testsuite".

On Wed, Feb 3, 2016 at 4:36 PM, Pierre-Anthony Lemieux <
notifications@github.com> wrote:

test/
w3c/
contrib/
dece/
skynav/

putting the "formal" testsuite files into test/w3c

See #152 (comment)
#152 (comment)


Reply to this email directly or view it on GitHub
#153.

@palemieux
Copy link
Contributor Author

I see you didn't quite adopt the indicated directory structure.

I have:

  • /testsuite/w3c (with the w3c tests)
  • /testsuite/contrib/skynav
  • /testsuite/contrib/dece

Is that not what you suggested, modulo testsuite->test?

lso, it would be better to rename the top node to test rather than testsuite, since not all of its content is the "testsuite".

Ok

@skynavga
Copy link
Contributor

skynavga commented Feb 5, 2016

What branch are you in? master isn't showing that. See [1].

[1] https://github.com/w3c/imsc/tree/master/testsuite

On Thu, Feb 4, 2016 at 8:37 PM, Pierre-Anthony Lemieux <
notifications@github.com> wrote:

I see you didn't quite adopt the indicated directory structure.

I have:

  • /testsuite/w3c (with the w3c tests)
  • /testsuite/contrib/skynav
  • /testsuite/contrib/dece

Is that not what you suggested, modulo testsuite->test?

lso, it would be better to rename the top node to test rather than
testsuite, since not all of its content is the "testsuite".

Ok


Reply to this email directly or view it on GitHub
#153 (comment).

@palemieux
Copy link
Contributor Author

Branch issue-153 (see PR #155)

palemieux added a commit that referenced this issue Feb 6, 2016
Addresses #153 ("Refactor test directory")
@palemieux palemieux modified the milestones: imsc1-cr4, imsc1-pr Feb 18, 2016
@palemieux palemieux removed the pr open label Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants