Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve itts:forcedDisplay description #284

Closed
palemieux opened this issue Nov 21, 2017 · 3 comments
Closed

Improve itts:forcedDisplay description #284

palemieux opened this issue Nov 21, 2017 · 3 comments
Assignees
@palemieux
Labels
imsc1.0.1
Milestone
imsc1.0.1 PR

Comments

@palemieux
Copy link
Contributor

From an implementer:

i was having trouble parsing the indicated text from the specification:

"If and only if the value of displayForcedOnlyMode is "true", a
content element with a itts:forcedDisplay computed value of "false"
shall not produce any visible rendering, but still affect layout,
regardless of the computed value of tts:visibility."

the following being the dilemma - in the above case, layout is affected in the sense that the invisible content element counts towards presentation (tts:visibility?) OR it is affected in the sense that it is not considered for presentation (tts:display?)

Proposed amended text:

If and only if the value of displayForcedOnlyMode is "true", a
content element with a itts:forcedDisplay computed value of "false"
shall not produce any visible rendering,
regardless of the computed value of tts:visibility.

The itts:forcedDisplay attribute has no affect on content layout or
composition, but merely determines whether composed content is visible
or not.

This follows the prose of tts:visibility in TTML1.
@palemieux palemieux added this to the imsc1.0.1 PR milestone Nov 21, 2017
@palemieux palemieux self-assigned this Nov 21, 2017
@nigelmegitt
Copy link
Contributor

I'm happy with the proposed wording in itself, but I'm not sure if it addresses the original comment. I think it would be clearer if we just said that in under the appropriate conditions the used value of tts:visibility shall be false for the element and all its descendants, regardless of the computed value of tts:visibility.

@palemieux
Copy link
Contributor Author

but I'm not sure if it addresses the original comment.

I verified with the commenter that they are happy with the proposed wording and that it addresses their comment.

@nigelmegitt
Copy link
Contributor

Okay, thanks. Is there any particular reason the commenter has not raised this directly and/or added a comment to the issue?

palemieux added a commit that referenced this issue Jan 9, 2018
@palemieux
Clarify forcedDisplay semantics (#284)
acbb5ef
@palemieux palemieux mentioned this issue Jan 9, 2018
Merged
palemieux added a commit that referenced this issue Jan 23, 2018
@palemieux
Clarify forcedDisplay semantics (#284)
97c568a
@palemieux palemieux removed the pr open label Jan 29, 2018
palemieux added a commit that referenced this issue Feb 6, 2018
@palemieux
Clarify forcedDisplay semantics (#284)
24a7e64
palemieux added a commit that referenced this issue Mar 8, 2018
@palemieux
Port IMSC1.0.1 fixes
3212412 
* Clarify fillLineGap semantics when applied to successive p elements (#263)
* Editorial tweaks (Close #271)
* Clarify forcedDisplay semantics (#284)
* Clarify the limits of Active Area per its syntax (#288)
* Clarify handling of foreign elements and attributes (#213)
* Clarify name of IMSC namespaces (#301)
* Use Root Container Region consistently (#302)
* Clarify style resolution procedure (#300)
@plehegar plehegar mentioned this issue Apr 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
imsc1.0.1
Projects
None yet
Milestone
imsc1.0.1 PR
Development

No branches or pull requests
2 participants
@palemieux @nigelmegitt