-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
itts:fillLineGap is unclear about what it is filling between exactly #263
Comments
For illustration, assuming that document_1.ttml:
document_2.ttml:
|
Could you update the images to indicate to which document it refers? It seems that the images are not in the same order as the document examples. Image 1 corresponds to document 2, and image 2 to document 1. Is that right? |
@cconcolato Done. |
Answers to your questions @mikedo :
Yes, however lines can also be generated by text wrapping even in the absence of
No. As you identified, it is specified as applying only to At the moment this feature supports no requirements associated with adjacent I think @palemieux has covered your other questions. Paragraphs vs line breaks?An observation from the examples earlier in the thread: my starting point for understanding the semantic difference between
In the case of subtitles and captions, I think both apply in different circumstances, which might be a driver for extending the requirements. For example it may be reasonable to separate caption dialogue spoken by different people into distinct |
The Working Group just discussed
The full IRC log of that discussion<nigel> Topic: itts:fillLineGap is unclear about what it is filling between exactly #263<nigel> github: https://github.com//issues/263 <nigel> Pierre: Were you happy with the renders Nigel? <nigel> Nigel: Yes I think so. <nigel> Pierre: My proposal is not to make any normative changes in IMSC 1.0.1 but to add <nigel> .. informative text and those examples, as well as maximising the chances of using <nigel> .. roll-up harmoniously with fillLineGap, would resolve this issue. <nigel> .. It was not completely intuitive to me, but since fillLineGap didn't exist before, just saying <nigel> .. how to use it should work. <nigel> Cyril: Nigel you said line areas can be generated without `<br>`s? <nigel> Nigel: Yes, line areas can be generated by line wrapping. <nigel> SUMMARY: @palemieux to attempt to exemplify this without substantive changes. |
I do not see any issues with applying linegap to p elements. Both examples given from Pierre should not show any gap by definition of the feature.
Background color is extended to the full with of the line area. With two adjacent p elements with one row each there are just two line areas where the part with text is filled with background to to the full height of the line area. |
I hadn't thought of it that way @TairT - I see what you mean. Even though the spec doesn't say anything about behaviour between Thinking ahead - paddingBy the way, when applying this to TTML2 we may need to be careful about |
@TairT @nigelmegitt Below are revised renders based on #263 (comment) . Please confirm they meet your expectations. Timing on
Timing on
|
I think they look good @palemieux . |
* Clarify fillLineGap semantics when applied to successive p elements (#263) * Editorial tweaks (Close #271) * Clarify forcedDisplay semantics (#284) * Clarify the limits of Active Area per its syntax (#288) * Clarify handling of foreign elements and attributes (#213) * Clarify name of IMSC namespaces (#301) * Use Root Container Region consistently (#302) * Clarify style resolution procedure (#300)
While exploring a possible implementation of
itts:fillLineGap
, it is unclear which lines this applies to. It is inheritable but only applies to<p>
. Does that mean it applies only to all lines within the<p>
(i.e. as separated by<br/>
)? Does it also apply between the lines in adjacent<p>
(perhaps if they both have it set to true, including through inheritance)? If the former (only intra-<p>
lines), how does one fill gaps between all lines? If the latter (including inter-<p>
lines), how does one intentionally leave a gap between adjacent<p>
?This indirectly creates a semantic difference between
<p>
and<br/>
.I believe it is highly desirable to be able to fill all line gaps in a region. I'm not sure about the use case for enabling gaps between
<p>
.At a minimum, this needs clarification in IMSC1.0.1 (and thus IMSC1.1).
The text was updated successfully, but these errors were encountered: