Address line comments for issue-126 branch made by @nigelmegitt #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change EBU-TT-D encoding statement to remove specific reference to UTF-16 and mention EBU-TT-D recommendation for UTF-8. * Make EBU-TT-D example validate against EBU-TT-D schema by moving `tts:lineHeight` specification from `<body>` to `"baseStyle" <style>`. * Fix typo of supplemented * Tighten up wording re SMPTE-TT constraints and remove redundant bullet.
nigelmegitt
changed the title
This commit adds the complete example files from the spec, so that they can be individually loaded and validated. This doesn’t help with synchronising changes between the HTML document and the examples of course, so it’s just a handy reference material. Arguably they should have the .ttml extension since that’s the registered type extension, but xml is not exactly wrong and is more easily processed by generic XML processors.
Are you saying that tts:lineHeight is not normatively permitted on body in EBU-TT-D? Or is this just a case of an inaccurate schema. |
|
Yes, |
palemieux
added a commit
that referenced
this pull request
Feb 10, 2016
Address line comments for issue-126 branch made by @nigelmegitt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF-16 and mention EBU-TT-D recommendation for UTF-8.
tts:lineHeightspecification from<body>to"baseStyle" <style>.bullet.