Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix differences of XML and images for fillLineGap + show line area boundaries #234

Merged
merged 6 commits into from Jun 6, 2017
Merged

Fix differences of XML and images for fillLineGap + show line area boundaries #234

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f2a7da6
Fix differences of XML and images for fillLineGap
May 23, 2017
5676592
Fix size of first linegap image
May 23, 2017
3099b62
Show boundaries between line areas (#228)
palemieux May 30, 2017
63bc483
Added description of before-edge and after-edge lines overlapping
palemieux Jun 1, 2017
86a33bc
Thickened figure 1 lines
palemieux Jun 6, 2017
849bef9
Merge branch 'master' into issue-0233-fix-linegap-samples
palemieux Jun 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file modified imsc1/spec/figures/fillLineGap-example-figure-1.png
View file
Open in desktop
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion imsc1/spec/ttml-ww-profiles.html
View file
Open in desktop
Expand Up @@ -1040,7 +1040,8 @@ <h4>itts:fillLineGap</h4>

<figcaption>
Illustrative rendition of the example immediately above with <code>itts:fillLineGap="true"</code> removed (left) or
preserved (right). Blue lines have been added to show the boundaries between line areas.
preserved (right). Blue lines have been added to show the <em>before-edge</em> and <em>after-edge</em> of each line
area, which are coincident for successive line areas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reword this for clarity to "Blue lines have been added to show the vertical position of the before-edge and after-edge of adjacent line areas; those edges are coincident. The before-edge of the first line and the after-edge of the last line are omitted." ? Just trying to be absolutely clear about what we are showing or not showing here. Not a big deal for me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the original wording for the first part, but would add as Nigel proposed: "The before-edge of the first line and the after-edge of the last line are omitted."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The before-edge of the first line and the after-edge of the last line are omitted."

The last updated to the PR added these blue lines in the graphics.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not enough contrast to see those blue lines at the top and bottom - I could not easily tell if they are there or not. So I would say either change the colours somehow so they are all visible or take them out and add the descriptive text - I would be fine with @TairT 's compromise in #234 (comment)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palemieux Thanks for changing the images and the text, both fine for me. Although the lines at top and bottom are less visible than the others, I could still see them, so it would work for me. If you take one of Nigels proposals that is also fine with me. Possibly the revised version would already work. I made bottom and top lines a bit thicker.
linegap-revised

</figcaption>
</figure>
</section>
Expand Down