Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background-color feature per removal in TTML2 #295

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

palemieux
Copy link
Contributor

Closes #255

@palemieux palemieux added this to the imsc1.1 WD2 milestone Jan 15, 2018
@palemieux palemieux self-assigned this Jan 15, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but it includes a bunch of changes that aren't needed to resolve the background-color feature removal issue. Is there a merge dependency?


<td colspan='2'>prohibited</td>
</tr>

<tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes after this point seem to be not relevant to the issue.

@palemieux
Copy link
Contributor Author

@nigelmegitt It looks like this PR is build on top of a commit that had not been tidied. The extra changes are the results of the tidying pass. It will be resolved when it is merged.

@palemieux palemieux removed the pr open label Jan 25, 2018
@palemieux palemieux merged commit b5c86b8 into IMSC1.1 Jan 29, 2018
@palemieux palemieux deleted the issue-255-remove-mooted-background-color branch February 9, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants