Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prohibit simultaneous tts:origin and tts:position #296

Merged
merged 2 commits into from
Jan 29, 2018

Conversation

palemieux
Copy link
Contributor

Closes #289

@palemieux palemieux added this to the imsc1.1 WD2 milestone Jan 15, 2018
@palemieux palemieux self-assigned this Jan 15, 2018
Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but it includes some changes that are not relevant to position and origin. Is there a merge order dependency?

<p>The <code>tts:position</code> attribute SHALL NOT be present in a <a>Document Instance</a> if any
<code>tts:origin</code> attribute is also present.</p>
</section>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes after this point appear not to be relevant to fixing the origin and position issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palemieux palemieux removed the pr open label Jan 25, 2018
@palemieux palemieux merged commit 25b4109 into IMSC1.1 Jan 29, 2018
@palemieux palemieux deleted the issue-289-prohibit-position-and-origin branch February 9, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants