Address draft CR2 comments #417
Conversation
imsc1/spec/ttml-ww-profiles.html
Outdated
| @@ -2863,6 +2853,9 @@ <h3>Style Resolution</h3> | |||
|
|
|||
| <li><code>ebutts:multiRowAlign</code></li> | |||
| </ul> | |||
|
|
|||
| <p class="note">The style properties above can be specified as an attribute of the <code>initial</code> element specified at | |||
There was a problem hiding this comment.
Maybe replace "as an attribute" with "as attributes" ?
| @@ -2863,6 +2853,9 @@ <h3>Style Resolution</h3> | |||
|
|
|||
| <li><code>ebutts:multiRowAlign</code></li> | |||
| </ul> | |||
|
|
|||
| <p class="note">The style properties above can be specified as attributes of the <code>initial</code> element specified at | |||
There was a problem hiding this comment.
Why was this moved to an informative note rather than staying as a MAY at line 2844-5? Seems better to me to say "and MAY be specified as attributes of the initial element...".
There was a problem hiding this comment.
Because foreign attributes are already permitted by TTML2, so no permission needed here.
There was a problem hiding this comment.
Ah right, in that case we need to be clearer still, that not only are those attributes permitted, but that the semantics of initial apply to them when used in that context. There needs to be a normative statement in there somewhere. Otherwise there's no processing requirement that actually does something with the extension style attributes, they could conformantly just be ignored.
There was a problem hiding this comment.
The current prose states The following style properties are subject to the Style Resolution procedures specified at Section 10.4 of [[!ttml2-20180628]]. The latter includes tt:initial processing. Are you suggesting the prose should say:
The following style properties shall be subject to the Style Resolution procedures specified at Section 10.4 of [[!ttml2-20180628]]
There was a problem hiding this comment.
Sorry for the long pause, @palemieux , yes, that would be an excellent change.
There was a problem hiding this comment.
@nigelmegitt See update.
|
The Working Group just discussed The full IRC log of that discussion<nigel> Topic: Address draft CR2 comments imsc#417<nigel> github: https://github.com//pull/417 <nigel> Pierre: I addressed your comment Nigel <nigel> Nigel: That looks great, thank you! <nigel> .. [approves pull request] |
Closes #421