Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address draft CR2 comments #417

Merged
merged 4 commits into from Jul 12, 2018
Merged

Address draft CR2 comments #417

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01988d4
Address comments at https://lists.w3.org/Archives/Public/public-tt/20…
palemieux Jul 3, 2018
6833037
Clarify that tt:initial allows multiple style properties as specified…
palemieux Jul 3, 2018
2775b39
Fix typo
palemieux Jul 3, 2018
b7a59f0
Address https://github.com/w3c/imsc/pull/417#discussion_r200428106
palemieux Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 17 additions & 24 deletions imsc1/spec/ttml-ww-profiles.html
View file
Open in desktop
Expand Up @@ -1397,15 +1397,6 @@ <h2>Supported Features and Extensions</h2>
<td colspan="2">Partially supported via <code>#contentProfiles</code>, and <code>#profile</code>.</td>
</tr>

<tr>
<td>
<a href=
"https://www.w3.org/TR/2018/CR-ttml2-20180628/#feature-profile-full-version-2"><code>#profile-full-version-2</code></a>
</td>

<td colspan="2">Partially supported via <code>#presentation</code> and <code>#profile-version-2</code></td>
</tr>

<tr>
<td>
<a href="https://www.w3.org/TR/2018/CR-ttml2-20180628/#feature-region-timing"><code>#region-timing</code></a>
Expand Down Expand Up @@ -1910,17 +1901,6 @@ <h2>Supported Features and Extensions</h2>
<td>Partially supported via <code>#writingMode-horizontal</code>.</td>
</tr>

<tr>
<td>
<a href=
"https://www.w3.org/TR/2018/CR-ttml2-20180628/#feature-writingMode-vertical"><code>#writingMode-vertical</code></a>
</td>

<td><span class="permitted label">permitted</span></td>

<td><span class="prohibited label">prohibited</span></td>
</tr>

<tr>
<td>
<a href=
Expand Down Expand Up @@ -1953,6 +1933,17 @@ <h2>Supported Features and Extensions</h2>
<td><span class="permitted-deprecated label">permitted-deprecated</span></td>
</tr>

<tr>
<td>
<a href=
"https://www.w3.org/TR/2018/CR-ttml2-20180628/#feature-writingMode-vertical"><code>#writingMode-vertical</code></a>
</td>

<td><span class="permitted label">permitted</span></td>

<td><span class="prohibited label">prohibited</span></td>
</tr>

<tr>
<td>
<a href="https://www.w3.org/TR/2018/CR-ttml2-20180628/#feature-zIndex"><code>#zIndex</code></a>
Expand Down Expand Up @@ -2299,8 +2290,8 @@ <h3>Synchronization</h3>
<section>
<h3>Mapping the <a>Root Container Region</a> to the <a>Related Video Object</a></h3>

<p>The <a>Root Container Region</a> of a <a>Document Instance</a> SHALL be mapped to each image frame of the <a>Related Video
Object</a> according to the following:</p>
<p>The <a>Root Container Region</a> of a <a>Document Instance</a> SHALL be mapped to a rectangular area within each image
frame of the <a>Related Video Object</a> according to the following:</p>

<ol style="list-style-type: lower-roman;">
<li>the ratio of the width to the height of the rectangular area is equal to the display aspect ratio of the <a>Root
Expand Down Expand Up @@ -2851,8 +2842,7 @@ <h3>Hypothetical Render Model</h3>
<h3>Style Resolution</h3>

<p>The following style properties are subject to the <em>Style Resolution</em> procedures specified at Section 10.4 of
[[!ttml2-20180628]], and MAY be specified as an attribute of the <code>initial</code> element specified at Section 10.1.1 of
[[!ttml2-20180628]], instead of an attribute in the <em>TT Style Namespaces</em>:</p>
[[!ttml2-20180628]]:</p>

<ul>
<li><code>itts:fillLineGap</code></li>
Expand All @@ -2863,6 +2853,9 @@ <h3>Style Resolution</h3>

<li><code>ebutts:multiRowAlign</code></li>
</ul>

<p class="note">The style properties above can be specified as attributes of the <code>initial</code> element specified at
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this moved to an informative note rather than staying as a MAY at line 2844-5? Seems better to me to say "and MAY be specified as attributes of the initial element...".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because foreign attributes are already permitted by TTML2, so no permission needed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right, in that case we need to be clearer still, that not only are those attributes permitted, but that the semantics of initial apply to them when used in that context. There needs to be a normative statement in there somewhere. Otherwise there's no processing requirement that actually does something with the extension style attributes, they could conformantly just be ignored.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current prose states The following style properties are subject to the Style Resolution procedures specified at Section 10.4 of [[!ttml2-20180628]]. The latter includes tt:initial processing. Are you suggesting the prose should say:

The following style properties shall be subject to the Style Resolution procedures specified at Section 10.4 of [[!ttml2-20180628]]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long pause, @palemieux , yes, that would be an excellent change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nigelmegitt See update.

Section 10.1.1 of [[!ttml2-20180628]].</p>
</section>

<section>
Expand Down