Datatransfer additions, see #120

[johanneswilm]

---

Preview | Diff

[saschanaz]

I don't have a string opinion about the change itself, I believe either @masayuki-nakano or @mbrodesser would want to take a look at that part.

(Gecko doesn't seem to add a File to DataTransfer when I copy a png file to a contenteditable on Windows desktop, which is different from what #120 said. It does add one when DND happens.)

[johanneswilm]

@saschanaz This is a change that was decided upon at the November call. We tested it and found the file in Chrome and Firefox but not in Safari. We add this here to make it behave the same everywhere.

[johanneswilm]

@saschanaz I just tried again on Ubuntu, and Firefox did show the file. Let's try to make sure we follow the exact same procedure to test this. I did this:

1. Go to https://johanneswilm.github.io/input-events-testing/index.html
2. Enable the developer console
3. In a second tab, go to https://www.w3.org/
4. On the first image in the middle row, right-click and select "copy".
5. Go back to the first tab and paste the image in the contenteditable element (right under the title "Input events tests") by clicking into it and then typing ctrl+v.
6. Inspect the output for the beforeinput event in the developer console.

[saschanaz]

With those steps I do get a file object from DataTransfer. Probably a bug that it doesn't work as such for desktop files (while Chrome does give a file.)

[johanneswilm]

@saschanaz It seems like using [=xref=] broke it, so I have reverted that for now. Do you want to try doing that in some other way in this PR, or should we just make it part of a more generic PR to solve #129?

[saschanaz]

Fixed it myself 👍

[saschanaz]

BTW, we don't need [[HTML]] here when xref already includes it.

[saschanaz]

Approving, mostly for the syntax.

[mbrodesser]

CC @evilpies, as this might be interesting for you.

[johanneswilm]

Hey @mbrodesser,

On Thu, Dec 16, 2021 at 11:13 AM mbrodesser ***@***.***> wrote: @johanneswilm <https://github.com/johanneswilm>: can you please explain why the "text/uri-list" entry was added in this PR? The explanation in #128 (comment) <#128 (comment)> doesn't cover that. It seems neither Chrome nor Firefox currently support this, at least on Ubuntu 20.04.

I was basing this on the outcome of the November call [1] . But you're right, the last few comments there before the action indicate though that we should possibly make it more platform dependent to match the data transfer object of the paste event. Not sure how we would word that. I'm open for suggestions. [1] https://www.w3.org/2021/11/12-editing-minutes.html#a02 -- Johannes Wilm