Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang attribute to EDITING.md #220

Merged
merged 1 commit into from
Jul 12, 2020
Merged

Add lang attribute to EDITING.md #220

merged 1 commit into from
Jul 12, 2020

Conversation

xfq
Copy link
Member

@xfq xfq commented Jul 9, 2020

Fix #213.

@xfq
Copy link
Member Author

xfq commented Jul 9, 2020

I added lang to the img elements as well, but they actually do not have the lang attributes in the current jlreq document. Should I remove them in EDITING.md, or do we need to add lang for the img elements (because it specifies the language for the text in alt)?

@himorin
Copy link
Contributor

himorin commented Jul 9, 2020

I think some img elements in JLreq Note has lang="ja" (but none for lang="en"?)

@r12a
Copy link
Contributor

r12a commented Jul 10, 2020

Thanks for preparing this @xfq . I think we should keep the recommendation to use the lang attribute for images too. As you say, this can be useful for alt or title text. I'm not sure whether we need to retrofit that to the jlreq doc, if it's currently working ok.

We should also change the advice about linking to sections and figures, to recommend use of [[[ ]]] rather than the <a> markup currently recommended.

@xfq
Copy link
Member Author

xfq commented Jul 12, 2020

Thanks for preparing this @xfq . I think we should keep the recommendation to use the lang attribute for images too. As you say, this can be useful for alt or title text. I'm not sure whether we need to retrofit that to the jlreq doc, if it's currently working ok.

OK. Could you merge this PR?

We should also change the advice about linking to sections and figures, to recommend use of [[[ ]]] rather than the <a> markup currently recommended.

I just submitted #221 for this.

@r12a r12a merged commit 5849ef6 into gh-pages Jul 12, 2020
@xfq xfq deleted the xfq/editing-lang branch July 12, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lang attribute to EDITING.md
3 participants