Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port scripts into respec post-script by promise #264

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Apr 26, 2021

as proposal, closes #260

further items which could be investigated

  • (for use with respec) timing between initializeLang and respec processing: initializeLang need to run after respec
    • e.g. checking respec is loaded or not
  • whether to divide functions needs to be persistent (inizializeLang and switchLang) and only used with respec (else)?
  • switchLang should have tri-state for langs array (not to run updating texts multiple times on 'all')
    • by measuring with performance, switchLang processing takes only around 100msec and possible duplicated part (replacing text in header part by suitable lnaguage's one) takes 1/3. so no much gain by this.

💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Apr 27, 2021, 5:49 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 Related URL

Navigation timeout of 29615 ms exceeded

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Mar 4, 2024, 5:36 AM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 [Related URL]([object Object])

Navigation timeout of 28237 ms exceeded

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@himorin himorin changed the title [WIP] port scripts into respec post-script by promise port scripts into respec post-script by promise Apr 26, 2021
@himorin himorin requested review from xfq and r12a April 27, 2021 05:49
@kidayasuo
Copy link
Contributor

@r12a and this one, please. Thank you!

@kidayasuo
Copy link
Contributor

From JLReq TF meeting on 2024-2-27: We would like to include this fix to the next and possibly the final revision of JLReq. The fix was developed three years ago, reviewed and approved by one reviewer (@xfq).

@r12a, I would greatly appreciate it if you could add your review. If we do not hear from you in two weeks we would like to go ahead with merging. thanks!

@xfq
Copy link
Member

xfq commented Feb 27, 2024

(Note that this branch has conflicts that must be resolved.)

@r12a
Copy link
Contributor

r12a commented Feb 28, 2024

Sorry, i thought i'd already replied on this. It's been a long time since i wrote the code which is being changed here, and (1) it will take me a long time to review properly, (2) i am not familiar with how to use promises in JS.

Could someone indicate why the change is being made, and how it affects current functionality for the user?

Btw, i thought that the Japanese translations for the SOTD were provided by respec - we worked with them on localisation code. Could someone check the situation? (maybe @xfq).

@xfq
Copy link
Member

xfq commented Feb 29, 2024

Sorry, i thought i'd already replied on this. It's been a long time since i wrote the code which is being changed here, and (1) it will take me a long time to review properly, (2) i am not familiar with how to use promises in JS.

Could someone indicate why the change is being made, and how it affects current functionality for the user?

The change is being made because the current language switching function doesn't work. See #260

Btw, i thought that the Japanese translations for the SOTD were provided by respec - we worked with them on localisation code. Could someone check the situation? (maybe @xfq).

Their translation does not include SOTD, and their localisation code is not suitable for us IIRC. It is only suitable when the full document is in Japanese (static lang=ja, not dynamic switching).

@himorin himorin merged commit 119e6c4 into w3c:gh-pages Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language switching doesn't work for the spec metadata
4 participants