Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated per issue #287 #288

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Jul 14, 2021

closes #287.

@kidayasuo how about adding any other possible templates? (e.g. 編集会議issues with mention to a collecting issue and a text mentioning issue is for 編集会議 - should be indicated by label??)

@himorin himorin requested a review from kidayasuo July 14, 2021 04:43
@kidayasuo
Copy link
Contributor

If new templates reduce your maintenance work please go ahead.

@himorin himorin requested a review from r12a August 20, 2021 06:10
@@ -0,0 +1,13 @@
---
name: Add a topic to collection of common questions, issues and mistakes / 編集会議ネタの新規項目追加
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@himorin I don't really understand how this is different from using 'Other'.

I checked the Japanese translation, and that seems to say something different from the English name (Addition of new items for editorial meeting material), which might make the distinction you were aiming at, but i couldn't get that from the English.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are placing some operational workflows on this series of topics, and our aim to separate this from 'Other' is not this part but lines at the bottom.
Our internal naming (or internal slang in JL-TF) in Japanese '編集会議ネタ' is not for editing JLReq or related Notes, but some of JL-TF members are discussing to put some guideline-ish writings at publications from academic society. Of course, we would want to include some of these in possible JLReq 3rd edition, but nothing well discussed yet.

@kidayasuo
Copy link
Contributor

kidayasuo commented Jun 21, 2022

編集会議ネタ might not be relevant any more as the one Kobayashi-san is editing is the last article of the serial articles. Other changes look fine.

@himorin himorin requested a review from r12a July 21, 2022 07:02
@himorin
Copy link
Contributor Author

himorin commented Jul 21, 2022

removed one as suggested by @kidayasuo

@xfq
Copy link
Member

xfq commented Jul 22, 2022

FYI - GitHub now supports a new template format. Maybe we can try it in the future. See some examples below:

@himorin
Copy link
Contributor Author

himorin commented Jul 26, 2022

FYI - GitHub now supports a new template format. Maybe we can try it in the future. See some examples below:

Yeah,, I've noticed, but it seems for me no further advanced feature is not required for our current usage to create new issue, at this moment...

@r12a
Copy link
Contributor

r12a commented Jul 26, 2022

I spent a while trying it out, but couldn't figure out how to make it work. I could be useful for the i18n-request issue templates.

@himorin
Copy link
Contributor Author

himorin commented Jul 28, 2022

I spent a while trying it out, but couldn't figure out how to make it work. I could be useful for the i18n-request issue templates.

I'm not sure what was the target to be achieved, but something like this test case?

@r12a
Copy link
Contributor

r12a commented Jul 28, 2022

Thanks. That's interesting. Some things i noticed:

  1. it would be better if the initial text inside the input elements was a placeholder, rather than a value. Is that possible?
  2. Users don't seem to be able to type free form text into the comment - presumably one needs to provide a textarea for 'other comments'.
  3. i assume that we can add regular text around the form fields? (eg. for instructions)

I can't see the source code that lies behind all this, because it's in your fork. Could you explain how you did it? Thanks.

@himorin
Copy link
Contributor Author

himorin commented Jul 28, 2022

Thanks. That's interesting. Some things i noticed:

1. it would be better if the initial text inside the input elements was a placeholder, rather than a value. Is that possible?

updated.

2. Users don't seem to be able to type free form text into the comment - presumably one needs to provide a textarea for 'other comments'.

I really forgot about that. added.

3. i assume that we can add regular text around the form fields? (eg. for instructions)

yes. see updated one. (like name of specification part)

I can't see the source code that lies behind all this, because it's in your fork. Could you explain how you did it? Thanks.

please check following file for template under testing
https://github.com/himorin/i18n-request/blob/gh-pages/.github/ISSUE_TEMPLATE/test-request-a-check-of-a-self-review.yml

@r12a
Copy link
Contributor

r12a commented Aug 8, 2022

@himorin many thanks indeed for showing me how to do this! I have now converted all of our i18n-request new issues to use the YAML form approach. See https://github.com/w3c/i18n-request/issues/new/choose

@himorin
Copy link
Contributor Author

himorin commented Aug 12, 2022

@r12a Thank you for letting me know (of course I've noticed about PR, though), and congrats for success!

But, I'd go with current style for jlreq as in this PR:

  • for gap-analysis, we will include content automatically into WG Note document, and automatically inserted head tags (by YAML way) are harmful for presentation
  • 'ask a question' might be one possibility to use YAML, like we can have text description at the top of issue submission form, but not much gain for us compared to the current template, since almost no guideline for raising a question.

So, I'd request re-review on this PR from you (@r12a ) and @kidayasuo with the current PR.

@r12a
Copy link
Contributor

r12a commented Aug 16, 2022

@himorin i agree that you don't need to use the form-based approach for the templates you are editing. It seem this PR is just about translation, for which you are the expert, so i'm ok with the PR.

Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the side topic about YAML use. Not appropriate here, i agree. (But your help was very useful for the i18n-request repo.)

@himorin
Copy link
Contributor Author

himorin commented Aug 16, 2022

got +1 from @kidayasuo also (via direct conversation), merging this.

@himorin himorin merged commit 3ee62e4 into w3c:gh-pages Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Japanese issue template?
4 participants