-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated per issue #287 #288
Conversation
If new templates reduce your maintenance work please go ahead. |
@@ -0,0 +1,13 @@ | |||
--- | |||
name: Add a topic to collection of common questions, issues and mistakes / 編集会議ネタの新規項目追加 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@himorin I don't really understand how this is different from using 'Other'.
I checked the Japanese translation, and that seems to say something different from the English name (Addition of new items for editorial meeting material), which might make the distinction you were aiming at, but i couldn't get that from the English.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are placing some operational workflows on this series of topics, and our aim to separate this from 'Other' is not this part but lines at the bottom.
Our internal naming (or internal slang in JL-TF) in Japanese '編集会議ネタ' is not for editing JLReq or related Notes, but some of JL-TF members are discussing to put some guideline-ish writings at publications from academic society. Of course, we would want to include some of these in possible JLReq 3rd edition, but nothing well discussed yet.
編集会議ネタ might not be relevant any more as the one Kobayashi-san is editing is the last article of the serial articles. Other changes look fine. |
removed one as suggested by @kidayasuo |
Yeah,, I've noticed, but it seems for me no further advanced feature is not required for our current usage to create new issue, at this moment... |
I spent a while trying it out, but couldn't figure out how to make it work. I could be useful for the i18n-request issue templates. |
I'm not sure what was the target to be achieved, but something like this test case? |
Thanks. That's interesting. Some things i noticed:
I can't see the source code that lies behind all this, because it's in your fork. Could you explain how you did it? Thanks. |
updated.
I really forgot about that. added.
yes. see updated one. (like name of specification part)
please check following file for template under testing |
@himorin many thanks indeed for showing me how to do this! I have now converted all of our i18n-request new issues to use the YAML form approach. See https://github.com/w3c/i18n-request/issues/new/choose |
@r12a Thank you for letting me know (of course I've noticed about PR, though), and congrats for success! But, I'd go with current style for jlreq as in this PR:
So, I'd request re-review on this PR from you (@r12a ) and @kidayasuo with the current PR. |
@himorin i agree that you don't need to use the form-based approach for the templates you are editing. It seem this PR is just about translation, for which you are the expert, so i'm ok with the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the side topic about YAML use. Not appropriate here, i agree. (But your help was very useful for the i18n-request repo.)
got +1 from @kidayasuo also (via direct conversation), merging this. |
closes #287.
@kidayasuo how about adding any other possible templates? (e.g. 編集会議issues with mention to a collecting issue and a text mentioning issue is for 編集会議 - should be indicated by label??)