Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed html lang to ja for 'all' #31

Closed
wants to merge 1 commit into from

Conversation

himorin
Copy link
Contributor

@himorin himorin commented May 7, 2019

This will change lang attribute of whole document to 'ja' when 'All' display option is selected.

@himorin himorin requested a review from r12a May 7, 2019 04:58
@r12a
Copy link
Contributor

r12a commented May 7, 2019

@himorin i'm not sure why you want to set the lang attribute to ja on the html tag for All. Note that the subtitles in the SOTD are in English in this case, and that the English always precedes the Japanese, so lang="en" is more appropriate in my opinion.

@himorin
Copy link
Contributor Author

himorin commented May 9, 2019

I just thought about what the page contains (to make lang reflecting its contents' language), but not considered about targets of the document..
As in email (to public-jlreq-admin), page has lang=ja for each part of Japanese text, so it should be displayed correctly.

let me close this PR without merging.

@himorin himorin closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants