Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.3.8 second paragraph: Fix English for inter-character spacing of ruby #80 #81

Closed
wants to merge 2 commits into from

Conversation

macnmm
Copy link
Contributor

@macnmm macnmm commented Jun 19, 2019

(edit by @himorin to add reference link, this is for #80 )


Preview | Diff

@macnmm macnmm requested review from himorin and r12a June 19, 2019 17:31
@himorin
Copy link
Contributor

himorin commented Jun 20, 2019

not sure exactly, but second comma added to line 4043 is correct?

@macnmm
Copy link
Contributor Author

macnmm commented Jun 20, 2019

not sure exactly, but second comma added to line 4043 is correct?

I think it makes the clause more readable -- "...avoid misreading of the layout, and maintain its beauty" could be a further improvement if the embedded commas bother people.

In fact, the original could say "...avoid misreading of the base text, as well as maintain the beauty of the layout.", but instead the clause "avoid misreading and maintain the beauty of" makes it ambiguous what is the object of "misreading". In my opinion, anyway. :)

I think I like that last edit better now that I look at it. I will propose it.

@himorin
Copy link
Contributor

himorin commented Jun 21, 2019

note: may need to think about #85 (comment) also

@xfq
Copy link
Member

xfq commented Jun 21, 2019

#85 is a larger issue around the use of the word "spaces". Since we already have a PR for #80 (which is this PR), I think other instances of "spaces" can be fixed separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants