-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toRdf/0118 fails in JSON-LD 1.1 #205
Comments
I think it is risky to introduce a backward incompatibility, so +1 to to @gkellogg 's solution. |
Using a blank node as a prefix sounds like total nonsense to me. I'm not even sure what the use case would have ever been. I'd prefer to make this a JSON-LD 1.0-only test. |
Note that this is unlike the Activity Streams use of |
in that case, +1 to marking it as 1.0 only and banning bnode prefixes from 1.1. |
We will probably need to reconsider this, as the WG decided to not break this 1.0 feature... The rationale was that, if the feature had tests written for it, it is hard to argue that it was unintentional or not thought through... Not that we enjoyed coming to that conclusion :-/ |
…ter, **if it is an IRI**. Fixes #205.
…ter, **if it is an IRI**. Fixes #205.
…ter, **if it is an IRI**. Fixes #205.
Since we added a provision in Create Term Definition that for simple terms to be used as prefixes, they need to end in a genDelim character, toRdf/0118 does not render the same results.
The relevant part of this test is the following:
This previously expanded to the following:
Now it generates the following:
This is because the new test does not use "term" as a prefix, so it's treated as a scheme.
We could either update the algorithm to allow blank node terms to be used as prefixes, or make this a 1.0-only test. As the general trend for us is to deprecate blank node terms, this might be the way to go. Note that a workaround would be to make it an expanded term definition with
@prefix
set to true. But, this might affect contexts such as that used by Activity Streams, so the safest thing would be to update 16.6 as follows:We could add another note about the use of blank node properties as being obsolete.
The text was updated successfully, but these errors were encountered: