-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in Create Term Definition relating to test ttn02 and handling of @none #259
Comments
Yes, |
pchampin
added a commit
that referenced
this issue
Dec 20, 2019
pchampin
added a commit
that referenced
this issue
Dec 20, 2019
This reverts commit adc2f48. This commit was supposed to be pushed into a PR branch, not directly into master. Sorry 8-/
pchampin
added a commit
that referenced
this issue
Dec 20, 2019
See PR #268 |
This issue was discussed in a meeting.
View the transcriptProcessing@none Rob Sanderson: #259 Rob Sanderson: Now a bunch of issues with the algorithms in the API doc, which come from my engineer who is implementing framing from scratch in perl. Gregg Kellogg: They are small things, but important things to correct nevertheless. … I don’t think any of them fundamentally change the output. Ivan Herman: That’s what CR is for. Rob Sanderson: This issue is how @none is handled.Gregg Kellogg: pchampin has a PR for this. Pierre-Antoine Champin: Yes, I did a PR for a few of the issues, as they are quite straightforward. Gregg Kellogg: It would be good to mention the issue in the PR, so we have a link between them. Proposed resolution: Agree @none is missing in 13.4, accept pchampin’s PR #268, and close (Rob Sanderson)Ruben Taelman: +1 Pierre-Antoine Champin: +1 Rob Sanderson: +1 Adam Soroka: +1 Tim Cole: +1 Gregg Kellogg: +1 Jeff Mixter: +1 Ivan Herman: +1 Resolution #4: Agree @none is missing in 13.4, accept pchampin’s PR #268, and close |
@kasei |
gkellogg
pushed a commit
that referenced
this issue
Dec 20, 2019
gkellogg
pushed a commit
that referenced
this issue
Dec 20, 2019
@gkellogg yes, looks good. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Create Term Definition step 13.3 says:
Step 13.4 immediately follows with an "otherwise" clause. However, if
type
is@none
andprocessing mode
isjson-ld-1.1
, the "otherwise" in 13.4 would seem to always raise an error condition. Test ttn02 seems to confirm that this wording is wrong. The intended conditional would seem to be something like:That is, the "otherwise" in 13.4 is paired only with the condition of
type
being@json
or@none
(but not the check ofprocessing mode
).The text was updated successfully, but these errors were encountered: