Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Create Term Definition relating to test ttn02 and handling of @none #259

Closed
kasei opened this issue Dec 19, 2019 · 5 comments
Closed

Comments

@kasei
Copy link

@kasei kasei commented Dec 19, 2019

Create Term Definition step 13.3 says:

If the expanded type is @JSON or @none, and processing mode is json-ld-1.0, an invalid type mapping error has been detected and processing is aborted.

Step 13.4 immediately follows with an "otherwise" clause. However, if type is @none and processing mode is json-ld-1.1, the "otherwise" in 13.4 would seem to always raise an error condition. Test ttn02 seems to confirm that this wording is wrong. The intended conditional would seem to be something like:

13.3) If the expanded type is @json or @none:
	If processing mode is json-ld-1.0, an invalid type mapping error has been detected and processing is aborted.
13.4) Otherwise, ...

That is, the "otherwise" in 13.4 is paired only with the condition of type being @json or @none (but not the check of processing mode).

@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 20, 2019

Yes, @none is missing from 13.4.

@gkellogg gkellogg added the wr:open label Dec 20, 2019
pchampin added a commit that referenced this issue Dec 20, 2019
pchampin added a commit that referenced this issue Dec 20, 2019
This reverts commit adc2f48.

This commit was supposed to be pushed into a PR branch,
not directly into master. Sorry 8-/
pchampin added a commit that referenced this issue Dec 20, 2019
@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 20, 2019

See PR #268

@iherman

This comment has been minimized.

Copy link
Member

@iherman iherman commented Dec 20, 2019

This issue was discussed in a meeting.

  • RESOLVED: Agree <code>@none</code> is missing in 13.4, accept pchampin’s PR #268, and close
View the transcript Processing @none
Rob Sanderson: #259
Rob Sanderson: Now a bunch of issues with the algorithms in the API doc, which come from my engineer who is implementing framing from scratch in perl.
Gregg Kellogg: They are small things, but important things to correct nevertheless.
… I don’t think any of them fundamentally change the output.
Ivan Herman: That’s what CR is for.
Rob Sanderson: This issue is how @none is handled.
Gregg Kellogg: pchampin has a PR for this.
Pierre-Antoine Champin: Yes, I did a PR for a few of the issues, as they are quite straightforward.
Gregg Kellogg: It would be good to mention the issue in the PR, so we have a link between them.
Proposed resolution: Agree @none is missing in 13.4, accept pchampin’s PR #268, and close (Rob Sanderson)
Ruben Taelman: +1
Pierre-Antoine Champin: +1
Rob Sanderson: +1
Adam Soroka: +1
Tim Cole: +1
Gregg Kellogg: +1
Jeff Mixter: +1
Ivan Herman: +1
Resolution #4: Agree @none is missing in 13.4, accept pchampin’s PR #268, and close
@azaroth42 azaroth42 moved this from Discuss-Call to Editorial Work in JSON-LD Management Dec 20, 2019
@gkellogg

This comment has been minimized.

Copy link
Member

@gkellogg gkellogg commented Dec 20, 2019

@kasei @none added to 13.4. Please indicate your satisfaction with the update.

@gkellogg gkellogg added wr:pending and removed wr:open labels Dec 20, 2019
@gkellogg gkellogg moved this from Editorial Work to Editorial work complete in JSON-LD Management Dec 21, 2019
@kasei

This comment has been minimized.

Copy link
Author

@kasei kasei commented Dec 22, 2019

@gkellogg yes, looks good. Thanks.

@gkellogg gkellogg closed this Dec 23, 2019
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management Dec 23, 2019
kasei added a commit to kasei/perl-jsonld that referenced this issue Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.