Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing use of override protected in Expansion #301

Closed
kasei opened this issue Jan 3, 2020 · 2 comments
Closed

Missing use of override protected in Expansion #301

kasei opened this issue Jan 3, 2020 · 2 comments
Labels
wr:commenter-agreed wr:spec-updated

Comments

@kasei
Copy link
Contributor

kasei commented Jan 3, 2020

Expansion step 8 seems to be missing use of a true override protected argument in the call to the Context Processing algorithm.

https://gist.github.com/kasei/c26e10b0defadcc9ab9143782b644087
gkellogg added a commit that referenced this issue Jan 3, 2020
@gkellogg
Add missing _override proected_ option for expanding with a property-…
bf94534 
…scoped context.

For #301.
@gkellogg gkellogg mentioned this issue Jan 3, 2020
Merged
@gkellogg
Copy link
Member

gkellogg commented Jan 3, 2020

@kasei this got lost in some intervening PR, see if this does it.

@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management DEPRECATED Jan 3, 2020
@kasei
Copy link
Contributor Author

kasei commented Jan 3, 2020

@gkellogg looks good, thanks!

gkellogg added a commit that referenced this issue Jan 3, 2020
@gkellogg
Add missing _override proected_ option for expanding with a property-…
91da9c1 
…scoped context.

For #301.
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management DEPRECATED Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wr:commenter-agreed wr:spec-updated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kasei @gkellogg