Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the errata management file #483

Merged
merged 3 commits into from
May 1, 2020
Merged

Added the errata management file #483

merged 3 commits into from
May 1, 2020

Conversation

iherman
Copy link
Member

@iherman iherman commented Apr 30, 2020

The file will be served from

https://w3c.github.io/json-ld-api/errata/

(although we may want to set up redirections from W3C, to be discussed...)

See: https://raw.githack.com/w3c/json-ld-api/add-errata/errata/index.html for now.

If this is fine, the same file will be added to the syntax and framing specs (maybe to streaming?), with obvious copy-paste actions.

@davidlehn
Copy link
Contributor

The errata.css that's being pulled in sets line-height on body. That makes the long h1 title look bad when it wraps. The bottom of 1st line touches top of 2nd line. May deserve an issue in another repo.

Are the accepted "Errata" issues supposed to be kept open? A bit unclear in the text. I'm guessing the search will find open or closed with the proper label.

@azaroth42
Copy link
Contributor

👍 to @davidlehn. I see it as:

Screen Shot 2020-04-30 at 1 29 46 PM

when I resize the browser width down

- Added a local version of the css file and removed the line-height setting (no idea why that would be necessary
- Made the title shorter because it was too long anyway
- I have also added an explanation to the text, whereby:

> All issues, labeled by “Errata”, are displayed in this report, whether they are opened or closed. Their status is added to the report on the individual errata.
@iherman
Copy link
Member Author

iherman commented May 1, 2020

The errata.css that's being pulled in sets line-height on body. That makes the long h1 title look bad when it wraps. The bottom of 1st line touches top of 2nd line. May deserve an issue in another repo.

Are the accepted "Errata" issues supposed to be kept open? A bit unclear in the text. I'm guessing the search will find open or closed with the proper label.

I have made an extra commit:

  • Added a local version of the css file and removed the line-height setting (no idea why that would be necessary
  • Made the title shorter because it was too long anyway
  • I have also added an explanation to the text, which says:

All issues, labeled by “Errata”, are displayed in this report, whether they are opened or closed. Their status is added to the report on the individual errata.

iherman added a commit to w3c/display_errata that referenced this pull request May 1, 2020
- Removed the line-height setting (no idea why that would be necessary...)
- I have also added an explanation to the text, whereby:

> All issues, labeled by “Errata”, are displayed in this report, whether they are opened or closed. Their status is added to the report on the individual errata.
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from having a section 1 and no section 2 (which I can live with), looks ok.

@iherman
Copy link
Member Author

iherman commented May 1, 2020

Apart from having a section 1 and no section 2 (which I can live with), looks ok.

Yep; I have actually removed the TOC. For a single document case it does not make sense.

@gkellogg gkellogg merged commit 828905a into master May 1, 2020
gkellogg pushed a commit that referenced this pull request May 1, 2020
- Added a local version of the css file and removed the line-height setting (no idea why that would be necessary
- Made the title shorter because it was too long anyway
- I have also added an explanation to the text, whereby:

> All issues, labeled by “Errata”, are displayed in this report, whether they are opened or closed. Their status is added to the report on the individual errata.
@gkellogg gkellogg deleted the add-errata branch May 1, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants