Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords for options #37

Closed
iherman opened this issue Feb 11, 2019 · 7 comments
Closed

Keywords for options #37

iherman opened this issue Feb 11, 2019 · 7 comments

Comments

@iherman
Copy link
Member

iherman commented Feb 11, 2019

Why isn't there a keyword for all options systematically? There is @embed, @explicit (although I am not sure its choice is the best, but that is bike shedding), but there isn't any @omit-default, @omit-graph, @require-all.

I think the reason may be that if, say, requireAll is an API flag, then it is global and not per frame. However, if that is the reason, the question becomes: why can't those flags be frame specific?

@iherman
Copy link
Member Author

iherman commented Feb 22, 2019

This issue was discussed in a meeting.

  • RESOLVED: Keep #37 open for @omit-graph
View the transcript 3.1. Keywords for options
Simon Steyskal: #37
Rob Sanderson: ivan asks why there isn’t a keyword for all the different options
Ivan Herman: I realized by reading through the document that certain options appeared as keywords
… others don’t
Gregg Kellogg: I think there are if you look at the syntax tokens
Gregg Kellogg: https://w3c.github.io/json-ld-framing/#framing-keywords
Ivan Herman: not sure I remember reading this
Gregg Kellogg: we very well may have examples that don’t use all the keywords
Rob Sanderson: > Initialize flags embed, explicit, and requireAll from object embed flag, explicit inclusion flag, and require all flag in state overriding from any property values for @embed, @explicit, and @requireAll in frame.
Ivan Herman: yeah the examples in the syntax document were way more extensive
Dave Longley: was just going to say our implementation has those flags in there (and there may be tests as well… at least i hope so) :)
Gregg Kellogg: my thought initially was that framing would eventually be incorporated in the API document
… but we decided to leave it in a sep. doc
… so there’s a backlog of things that have to happen to the document
Tim Cole: Does 4.1 include @omit-graph?
Ivan Herman: clearly, if we add more examples to the document then this should fix it
Proposed resolution: Close Framing #37, as already fixed (Rob Sanderson)
Gregg Kellogg: there is an open issue I’m working against
Rob Sanderson: +1
Pierre-Antoine Champin: +1
Gregg Kellogg: no it’s in 4.4.3.3
Benjamin Young: is it a keyword? or an option for the api?
Gregg Kellogg: well we have keywords for all the options
Proposed resolution: Keep #37 open for @omit-graph (Rob Sanderson)
Simon Steyskal: +1
Ivan Herman: +1
Rob Sanderson: +1
Tim Cole: +1
Benjamin Young: +1
Dave Longley: +1 … naming convention appears to be camelCase so @omitDefault
Gregg Kellogg: +1
Gregg Kellogg: values can have multiple elements (array) part of the reason why this complicates native json support
David I. Lehn: +1
David Newbury: +1
Resolution #2: Keep #37 open for @omit-graph

@gkellogg
Copy link
Member

I'm not sure @omitGraph would be particularly useful, as it is only useful at the very top-level and the algorithm doesn't consider it as a possible default when processing a frame object.

Note that it defaults to true in 1.1, which is probably what most people want. Adding it to the frame is kind of odd, though.

@iherman
Copy link
Member Author

iherman commented Feb 23, 2019

True. But I guess it would require more explanation to describe why this (or other) API flag does not have a keyword equivalent... Furthermore, by using this keyword (and others) the creator of a frame ensures that this statement is always there, regardless of how a particular JSON-LD processor is invoked, ie, how the API flags are set...

@gkellogg
Copy link
Member

gkellogg commented Mar 1, 2019

See #41, which would remove @omitDefault while possibly keeping the flag.

In the case of the omit graph flag, it is never encountered when processing a frame, and it would require something extra to reach into the frame to see if this had been set. The default in 1.1 is to omit it, and the flag mostly exists to be able to explicitly go back to the 1.0 behavior.

@azaroth42 azaroth42 moved this from Discuss-Call to Editorial Work in JSON-LD Management Mar 7, 2019
@azaroth42
Copy link
Contributor

So we can close?

@gkellogg gkellogg moved this from Editorial Work to Discuss-GH in JSON-LD Management Mar 28, 2019
@azaroth42
Copy link
Contributor

@iherman
Copy link
Member Author

iherman commented Mar 29, 2019

This issue was discussed in a meeting.

  • RESOLVED: Close #37, only edge edge cases when there is disparity
View the transcript 4.5. Keywords / Flags
Ivan Herman: link: #37
Rob Sanderson: would we have complete parity between keywords and flags?
Proposed resolution: Close #37, only edge cases when there is disparity (Rob Sanderson)
Rob Sanderson: +1
Ivan Herman: we have the parity for most of them;
Ivan Herman: +1
Dave Longley: +1
Ruben Taelman: +1
Gregg Kellogg: +1
Tim Cole: +1
Ivan Herman: those were we don’t are edge cases, so I’m fine with closing it
Pierre-Antoine Champin: +1
David Newbury: +1
David I. Lehn: +1
Resolution #4: Close #37, only edge edge cases when there is disparity
Adam Soroka: +1

@azaroth42 azaroth42 moved this from Discuss-GH to Editorial Work in JSON-LD Management Apr 4, 2019
@gkellogg gkellogg removed this from Editorial Work in JSON-LD Management Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants