requireAll does not require @type and should

[azaroth42]

From discussion on the mailing list, it was noted that the requireAll flag does not actually require all, it requires everything other than @id and @type.

The proposal arising is to make it actually require all of the asserted features, including @type and @id.

[dlongley]

We might need to tweak the proposal a bit -- because right now I think requireAll would require @type if present (because when @type is present it is always required). The problem is that it doesn't require any of the other properties when @type is present. The proposal is to make it such that when @type is present, all of the other properties are also required.

[dlongley]

Or, more generally, when requireAll is true, all specific properties must be present or there is no match. There is no special treatment of @type or @id.

[iherman]

This issue was discussed in a meeting.

• RESOLVED: If requireAll is present, then all keys in the frame are used to determine a match, including @type and @id

View the transcript

3. requireAll does not require @type and should
Rob Sanderson: #40
Gregg Kellogg: we added require all flag that does not work the way people expect. People expected it to literally mean ‘require all’ not a combination of if/or
Ivan Herman: can we close the issue?
Gregg Kellogg: not close but we agree to move to approve it
Proposed resolution: IF requireAll is present, then all keys in the frame are used to determine a match, including @type and @id (Rob Sanderson)
Gregg Kellogg: seems logical to be if require all is present then all keys in the frame are used to determine that
Gregg Kellogg: +1
Dave Longley: +1
Rob Sanderson: +1
Benjamin Young: +1
Jeff Mixter: +1
Ivan Herman: +1
Tim Cole: +1
Harold Solbrig: +1
Simon Steyskal: +1
David Newbury: +1
David I. Lehn: +1
Resolution #2: If requireAll is present, then all keys in the frame are used to determine a match, including @type and @id