Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 43 embed first #44

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Issue 43 embed first #44

merged 3 commits into from
Mar 13, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Mar 10, 2019 •
edited by pr-preview bot
Loading

Depends on #42 being merged first.

Fixes #43.

Preview | Diff

@gkellogg gkellogg requested a review from dlongley March 10, 2019 22:42
dlongley
dlongley approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than that one line that had the wrong default set (it should now be @first). Of course, we'll have to implement @first to make sure that the steps work as expected, etc.

index.html Outdated Show resolved Hide resolved
@dlongley
Copy link
Contributor

Thanks, @gkellogg!

@gkellogg
Copy link
Member Author

Note there’s inline issues about the potential cost of ordering implied in either @first or @last.

@gkellogg gkellogg merged commit d770615 into master Mar 13, 2019
@gkellogg gkellogg deleted the issue-43-embed-first branch March 13, 2019 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gkellogg @dlongley