Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case for credentials framing. #63

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Test case for credentials framing. #63

merged 1 commit into from
Aug 30, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Aug 8, 2019

Fixes #27.

@gkellogg gkellogg requested a review from dlongley August 8, 2019 20:36
@dlongley
Copy link
Contributor

dlongley commented Aug 9, 2019

I see this @gkellogg -- thanks! I haven't had a chance to look at it yet but will review when I can to make sure it's doing what we need.

@gkellogg gkellogg added this to Editorial work complete in JSON-LD Management DEPRECATED Aug 14, 2019
@gkellogg gkellogg mentioned this pull request Aug 19, 2019
Closed
dlongley
dlongley approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the right result to me.

@gkellogg gkellogg merged commit 1aff7e8 into master Aug 30, 2019
@gkellogg gkellogg deleted the issue-27 branch August 30, 2019 22:07
@gkellogg gkellogg removed this from Editorial work complete in JSON-LD Management DEPRECATED Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

Assignees
No one assigned
Labels
test:missing-coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Framing blank node unnamed graphs
2 participants
@gkellogg @dlongley