Update included block example based on ones either side #348
Conversation
index.html
Outdated
| "classification": {"@type": "@vocab"}, | ||
| "service": {"@type": "@vocab"} | ||
| "team": {"@type": "@vocab"} |
There was a problem hiding this comment.
Does this statement (and the previous one) add anything to the example? Ie, is it necessary to have it here? At first glance I do not think so; if that is correct, it is better to remove it as just blurring the essence of the example.
There was a problem hiding this comment.
Yes, we could settle on either "classification" or "team", don't need both.
There was a problem hiding this comment.
Actually, I was wondering about "@type":"@value", not the fact of having both...
| "http://example.org/classification": [ | ||
| {"@id": "http://example.org/enum#c6"} | ||
| {"@id": "http://example.org/employee"} |
There was a problem hiding this comment.
The statement on the name of Manu is missing...
There was a problem hiding this comment.
That could be told by running the "rake" task, which is also noted by travis. It checks that the first example matches the things in the second example after running through the algorithms.
bundle install
rakeThat's all that should be necessary.
| "http://example.org/classification": [ | ||
| {"@id": "http://example.org/enum#c6"} | ||
| {"@id": "http://example.org/contractor"} |
There was a problem hiding this comment.
The statement on the name of Gregg is missing...
index.html
Outdated
| "classification": {"@type": "@vocab"}, | ||
| "service": {"@type": "@vocab"} | ||
| "team": {"@type": "@vocab"} |
There was a problem hiding this comment.
Yes, we could settle on either "classification" or "team", don't need both.
| "http://example.org/classification": [ | ||
| {"@id": "http://example.org/enum#c6"} | ||
| {"@id": "http://example.org/employee"} |
There was a problem hiding this comment.
That could be told by running the "rake" task, which is also noted by travis. It checks that the first example matches the things in the second example after running through the algorithms.
bundle install
rakeThat's all that should be necessary.
|
I wanted to demonstrate with the two different properties that it's not just a single relationship, it's a grab bag of any entities that you want to reference. If we don't think that's an issue, then yes, we can remove |
I don't see how this relates to included blocks; that's certainly what has been highlighted. |
Closes #255 ... finally!
💥 Error: 500 Internal Server Error 💥
PR Preview failed to build. (Last tried on Apr 14, 2020, 6:07 PM UTC).
More
PR Preview relies on a number of web services to run. There seems to be an issue with the following one:
🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.
🔗 Related URL
If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.