Add attribution for <frame>, <embed>, <object> #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm1
commented
Nov 28, 2019
|
Test being added in https://chromium-review.googlesource.com/c/chromium/src/+/1942877. Chrome fails object due to needing data instead of src. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 28, 2019
Matches spec change in w3c/longtasks#78 Change-Id: I5641d4a6f1424abe87e1fb9ce000ac776e5e84ed
tdresser
approved these changes
Dec 2, 2019
domenic
reviewed
Dec 2, 2019
Co-Authored-By: Domenic Denicola <d@domenic.me>
domenic
approved these changes
Dec 2, 2019
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 3, 2019
This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 3, 2019
This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 4, 2019
This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721258}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Dec 4, 2019
This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721258}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 9, 2019
…nerSrc in attribution, a=testonly Automatic update from web-platform-tests [Longtasks] Fix containerType and containerSrc in attribution This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721258} -- wpt-commits: e92918c7452f2ef99fe95545fdfb41a7787b9b94 wpt-pr: 20595
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Dec 9, 2019
…nerSrc in attribution, a=testonly Automatic update from web-platform-tests [Longtasks] Fix containerType and containerSrc in attribution This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721258} -- wpt-commits: e92918c7452f2ef99fe95545fdfb41a7787b9b94 wpt-pr: 20595
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 10, 2019
…nerSrc in attribution, a=testonly Automatic update from web-platform-tests [Longtasks] Fix containerType and containerSrc in attribution This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobeschromium.org> Commit-Queue: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#721258} -- wpt-commits: e92918c7452f2ef99fe95545fdfb41a7787b9b94 wpt-pr: 20595 UltraBlame original commit: a13898cb3364862002fb9de0e58f039c4c0a5b3e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 10, 2019
…nerSrc in attribution, a=testonly Automatic update from web-platform-tests [Longtasks] Fix containerType and containerSrc in attribution This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobeschromium.org> Commit-Queue: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#721258} -- wpt-commits: e92918c7452f2ef99fe95545fdfb41a7787b9b94 wpt-pr: 20595 UltraBlame original commit: a13898cb3364862002fb9de0e58f039c4c0a5b3e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 10, 2019
…nerSrc in attribution, a=testonly Automatic update from web-platform-tests [Longtasks] Fix containerType and containerSrc in attribution This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobeschromium.org> Commit-Queue: Nicolás Peña Moreno <npmchromium.org> Cr-Commit-Position: refs/heads/master{#721258} -- wpt-commits: e92918c7452f2ef99fe95545fdfb41a7787b9b94 wpt-pr: 20595 UltraBlame original commit: a13898cb3364862002fb9de0e58f039c4c0a5b3e
ns-rsilva
pushed a commit
to ns-rsilva/chromium
that referenced
this pull request
Apr 25, 2024
This CL brings the longtasks API up to date with the recent changes on w3c/longtasks#78. It also adds WPT tests for those changes. The changes are: * containerType is "window", "iframe", "embed", etc. depending on the type of the culprit browsing context container. * containerSrc is now the 'data' attribute when the container is an <object>. Change-Id: I06f661968778e3bec433a1bfe758b4604df01557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949146 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#721258} Former-commit-id: 7598e87a8495404cc97e8db34852714ea35920e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically #65 but doing a new PR because rebasing would've taken me longer.
Fixes #52
Preview | Diff